Closed Bug 1457802 Opened 2 years ago Closed 2 years ago

Remove some unused keyword tables from nsCSSProps

Categories

(Core :: CSS Parsing and Computation, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

No description provided.
Comment on attachment 8971903 [details]
Bug 1457802 part 1 - Remove nsCSSProps::GetColorName which is unused.

https://reviewboard.mozilla.org/r/240636/#review246654
Attachment #8971903 - Flags: review?(cam) → review+
Comment on attachment 8971904 [details]
Bug 1457802 part 2 - Remove pref callbacks touching keyword tables from nsLayoutUtils.

https://reviewboard.mozilla.org/r/240638/#review246656
Attachment #8971904 - Flags: review?(cam) → review+
Comment on attachment 8971905 [details]
Bug 1457802 part 3 - Remove unused keyword tables.

https://reviewboard.mozilla.org/r/240640/#review246658

I guess these are unused because they previously were only used for specified value parsing and serialization, and the remaining ones are still used for computed value serialization (for now)?
Attachment #8971905 - Flags: review?(cam) → review+
Yes, the remaining ones are still used for computed value serialization and some other places like accessibility.
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0bd3f2f95b55
part 1 - Remove nsCSSProps::GetColorName which is unused. r=heycam
https://hg.mozilla.org/integration/autoland/rev/3347987c7a8a
part 2 - Remove pref callbacks touching keyword tables from nsLayoutUtils. r=heycam
https://hg.mozilla.org/integration/autoland/rev/fef27fa9d5a7
part 3 - Remove unused keyword tables. r=heycam
You need to log in before you can comment on or make changes to this bug.