1457804 - Grid overlay is displayed in the wrong position for direction:rtl grid containers

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P2)

Description

[Mats Palmgren (inactive)]

Attachment: Testcase

STR:
1. load the attached testcase
2. open devtools inspector and select one of the grid elements
3. activate the grid overlay

ACTUAL RESULT
The grid overlay is rendered in the padding area.

ACTUAL RESULT
The grid overlay is rendered in the content area.

Comment 1

[Mats Palmgren (inactive)]

Attachment: Screenshot

The light blue areas are the padding areas.

Comment 2

[Mats Palmgren (inactive)]

Errrh, replace "padding" with "border" above of course...

Comment 3

[Mats Palmgren (inactive)]

Attachment: Testcase #2

Actually, the bug occurs for padding too...

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Bug 1457804 - Use content size for DevTools highlighter writing mode adjustments.

The writing mode / RTL adjustments performed by `getWritingModeMatrix` needs the
element's content size without margins, borders, or padding.

Review commit: https://reviewboard.mozilla.org/r/241618/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/241618/

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ea3d6a007a7a6709764deab65198d94a7311a54c

Comment 6

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8973078 [details]
Bug 1457804 - Use content size for DevTools highlighter writing mode adjustments.

https://reviewboard.mozilla.org/r/241618/#review247430

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/daaa9249868c
Use content size for DevTools highlighter writing mode adjustments. r=gl

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/daaa9249868c