1457967 - Build error in nsRect.h: SSE4.1 instruction set not enabled

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[:Felipe Gomes (needinfo for replies!)]

I'm building on OSX Yosemite, and the latest version of XCode here ships with an older version of clang.. I got this error when compiling after https://hg.mozilla.org/mozilla-central/rev/16a7ab26c645

5:47.13 In file included from /Users/felipe/moz/inbound/ff-opt/dist/include/nsRect.h:25:
5:47.13 /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/clang/7.0.2/include/smmintrin.h:28:2: error: "SSE4.1 instruction set not enabled"
5:47.13 #error "SSE4.1 instruction set not enabled"

Comment 1

[Bas Schouten (:bas.schouten)]

Attachment: Bug 1457967: Don't needlessly include smmintrin.h on platforms where we're only using SSE2.

Review commit: https://reviewboard.mozilla.org/r/241218/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/241218/

Comment 2

[:Felipe Gomes (needinfo for replies!)]

I should note that with the s/ifdef/if/ fix, this patch works for me

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8972677 [details]
Bug 1457967: Don't needlessly include smmintrin.h on platforms where we're only using SSE2.

https://reviewboard.mozilla.org/r/241218/#review247106

When builds

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/58fb973a0dad
Don't needlessly include smmintrin.h on platforms where we're only using SSE2. r=jrmuizel

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/58fb973a0dad