Closed Bug 1457967 Opened 3 years ago Closed 3 years ago
Build error in ns
Rect .h: SSE4 .1 instruction set not enabled
59 bytes, text/x-review-board-request
I'm building on OSX Yosemite, and the latest version of XCode here ships with an older version of clang.. I got this error when compiling after https://hg.mozilla.org/mozilla-central/rev/16a7ab26c645 5:47.13 In file included from /Users/felipe/moz/inbound/ff-opt/dist/include/nsRect.h:25: 5:47.13 /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/clang/7.0.2/include/smmintrin.h:28:2: error: "SSE4.1 instruction set not enabled" 5:47.13 #error "SSE4.1 instruction set not enabled"
I should note that with the s/ifdef/if/ fix, this patch works for me
Comment on attachment 8972677 [details] Bug 1457967: Don't needlessly include smmintrin.h on platforms where we're only using SSE2. https://reviewboard.mozilla.org/r/241218/#review247106 When builds
Attachment #8972677 - Flags: review?(jmuizelaar) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/58fb973a0dad Don't needlessly include smmintrin.h on platforms where we're only using SSE2. r=jrmuizel
You need to log in before you can comment on or make changes to this bug.