Closed Bug 1458011 Opened Last year Closed Last year

Don't allow the backing store behind a TypedObject to be accessed

Categories

(Core :: JavaScript Engine, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: Waldo, Assigned: Waldo)

Details

Attachments

(1 file)

From Paris just over a week ago, it sounds like typed objects as we're pushing them are not going to expose the underlying memory as ArrayBuffer.  Preserving this complexity in SpiderMonkey doesn't give you much, it's not going to be used in Web Assembly, and there's ongoing maintenance cost to keeping it around.

Let's remove the capability.  That is, let's remove:

* TypedObject.storage, the function that returns the ArrayBuffer beneath a typed object not containing any/reference
* the ability of TypedObject constructors to accept an ArrayBuffer to view
Attached patch PatchSplinter Review
This seems to pass jstests/jit-tests locally but has not been tryservered.
Attachment #8972114 - Flags: review?(sphink)
Comment on attachment 8972114 [details] [diff] [review]
Patch

Review of attachment 8972114 [details] [diff] [review]:
-----------------------------------------------------------------

/me pours one out.
Attachment #8972114 - Flags: review?(sphink) → review+
*applause*
Priority: -- → P1
FWIW this might well come back: transparent Typed Objects aren't required for the current plans for Wasm/JS integration, but they have value for other use cases.

I'm not opposed to removing this for now, but we might need to resurrect it at some point.
Pushed by jwalden@mit.edu:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b663c7fd766c
Remove the TypedObject.storage function and |new TypedObject(buffer [, offset])| constructor overload because they're no longer planned to be part of standardization efforts in this area.  r=sfink
https://hg.mozilla.org/mozilla-central/rev/b663c7fd766c
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.