1458011 - Don't allow the backing store behind a TypedObject to be accessed

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P1)

Description

[Jeff Walden [:Waldo]]

From Paris just over a week ago, it sounds like typed objects as we're pushing them are not going to expose the underlying memory as ArrayBuffer.  Preserving this complexity in SpiderMonkey doesn't give you much, it's not going to be used in Web Assembly, and there's ongoing maintenance cost to keeping it around.

Let's remove the capability.  That is, let's remove:

* TypedObject.storage, the function that returns the ArrayBuffer beneath a typed object not containing any/reference
* the ability of TypedObject constructors to accept an ArrayBuffer to view

Comment 1

[Jeff Walden [:Waldo]]

Attachment: Patch

This seems to pass jstests/jit-tests locally but has not been tryservered.

Comment 2

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8972114 [details] [diff] [review]
Patch

Review of attachment 8972114 [details] [diff] [review]:
-----------------------------------------------------------------

/me pours one out.

Comment 3

[Jason Orendorff [:jorendorff]]

*applause*

Comment 4

[Till Schneidereit [:till]]

FWIW this might well come back: transparent Typed Objects aren't required for the current plans for Wasm/JS integration, but they have value for other use cases.

I'm not opposed to removing this for now, but we might need to resurrect it at some point.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b663c7fd766c
Remove the TypedObject.storage function and |new TypedObject(buffer [, offset])| constructor overload because they're no longer planned to be part of standardization efforts in this area.  r=sfink

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/b663c7fd766c