145803 - Implement url autocomplete

Status: VERIFIED FIXED

(Camino Graveyard :: General, defect)

Description

[Winnie Lam]

Implement url autocomplete.

Comment 1

[Joe Hewitt (gone)]

Attachment: patch

This patch implements full url autocomplete, just like in Mozilla.

Comment 2

[Joe Hewitt (gone)]

Attachment: patch

This patch implements full url autocomplete, just like in Mozilla.

Comment 3

[Mike Pinkerton (not reading bugmail)]

+    mIconImage = [[NSImage imageNamed:@"globe_ico"] autorelease]; 

NSImage's are already autoreleased. i fixed this, but FYI.

+  [self setDelegate: self]; 

shouldn't this be done in IB?

+  if (mProxyIcon != nil) {

just |if (mProxyIcon) {|

+  mDataSource = [[[CHAutoCompleteDataSource alloc] init] retain];

retain is implied by the alloc. this will leak. again, i fixed it.

i also noticed that hitting esc doesn't make it dismiss, and if i click outside
it, it loads the url i click on in the content area. maybe that's ok, but it
just makes the popup very hard to dismiss w/out consequences.

Comment 4

[Joe Hewitt (gone)]

fixed

Comment 5

[Chris Petersen]

Verified in the 2002-06-04-05 trunk