Implement url autocomplete

VERIFIED FIXED

Status

Camino Graveyard
General
VERIFIED FIXED
16 years ago
16 years ago

People

(Reporter: Winnie Lam, Assigned: Joe Hewitt (gone))

Tracking

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

16 years ago
Implement url autocomplete.
(Reporter)

Updated

16 years ago
Blocks: 145820
(Reporter)

Updated

16 years ago
QA Contact: petersen → winnie
(Assignee)

Updated

16 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

16 years ago
Created attachment 85220 [details] [diff] [review]
patch

This patch implements full url autocomplete, just like in Mozilla.
(Assignee)

Comment 2

16 years ago
Created attachment 85221 [details] [diff] [review]
patch

This patch implements full url autocomplete, just like in Mozilla.
(Assignee)

Updated

16 years ago
Attachment #85220 - Attachment is obsolete: true
+    mIconImage = [[NSImage imageNamed:@"globe_ico"] autorelease]; 

NSImage's are already autoreleased. i fixed this, but FYI.

+  [self setDelegate: self]; 

shouldn't this be done in IB?

+  if (mProxyIcon != nil) {

just |if (mProxyIcon) {|

+  mDataSource = [[[CHAutoCompleteDataSource alloc] init] retain];

retain is implied by the alloc. this will leak. again, i fixed it.

i also noticed that hitting esc doesn't make it dismiss, and if i click outside
it, it loads the url i click on in the content area. maybe that's ok, but it
just makes the popup very hard to dismiss w/out consequences.

(Assignee)

Updated

16 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
(Assignee)

Comment 4

16 years ago
fixed

Comment 5

16 years ago
Verified in the 2002-06-04-05 trunk 
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.