Open
Bug 1458068
Opened 6 years ago
Updated 2 years ago
biquad-automation.html wpt test has data in test names
Categories
(Core :: Web Audio, enhancement, P2)
Core
Web Audio
Tracking
()
NEW
People
(Reporter: jgraham, Unassigned)
References
(Blocks 2 open bugs, )
Details
Attachments
(1 file, 1 obsolete file)
This is bad, because the names are supposed to be used as identifiers, but it's not clear that this data is constant.
|
Reporter | |
Comment 1•6 years ago
|
||
|
|
Reporter | |
Comment 2•6 years ago
|
||
Attachment #8972156 -
Attachment is obsolete: true
|
||
Comment 3•6 years ago
|
||
I agree that looks bad. Is there a WPT issue for this already?
Rank: 15
Priority: -- → P2
|
|
||
Comment 4•6 years ago
|
||
Comment on attachment 8972159 [details]
disable.patch
LGTM
Attachment #8972159 -
Flags: review+
|
||
Comment 5•6 years ago
|
||
For the record, the expected output is included in the message so you can tell what the output is. The attachment says the test fails, but it seems the last bit is left off, but it would have said something like "element-wise tolerance of {"absoluteThreshold":0.000027657,"relativeThreshold":0}" So the absolute difference between the actual and expected results exceeds 2.7657e-5. There would also be more text specifying what the actual max absolute (and relative) difference was.
|
||
Updated•5 years ago
|
Blocks: webaudio-wpt
|
||
Updated•5 years ago
|
| Comment hidden (spam) |
|
|
||
Updated•3 years ago
|
Flags: sec-bounty?
Flags: needinfo?(james)
Flags: in-testsuite+
Flags: in-qa-testsuite+
Flags: behind-pref+
|
||
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•