Closed Bug 1458091 Opened Last year Closed Last year

Fix tsan warning about ScriptSource::refs

Categories

(Core :: JavaScript Engine, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: tcampbell, Assigned: tcampbell)

References

Details

Attachments

(1 file)

This TSAN complaint is a false positive, but marking Atomic is the path of least resistance to making this code more boring.
Attachment #8972185 - Flags: review?(jdemooij)
Comment on attachment 8972185 [details] [diff] [review]
0001-Make-ScriptSource-refs-Atomic-to-please-TSAN.patch

Review of attachment 8972185 [details] [diff] [review]:
-----------------------------------------------------------------

Maybe a ReleaseAcquire atomic? I'm a little worried about perf overhead on ScriptSource finalization etc..
Attachment #8972185 - Flags: review?(jdemooij) → review+
Will use ReleaseAcquire here.
Pushed by tcampbell@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1e6cdcc88c36
Make ScriptSource::refs Atomic to please TSAN. r=jandem
https://hg.mozilla.org/mozilla-central/rev/1e6cdcc88c36
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.