Closed Bug 1458100 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 10723 - Attempt to make Config.ports() thread-safe

Categories

(Testing :: web-platform-tests, enhancement, P4)

enhancement

Tracking

(firefox61 fixed)

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 10723 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/10723
Details from upstream follow.

Robert Ma <robertma@chromium.org> wrote:
>  Attempt to make Config.ports() thread-safe
>  
>  Fixes #10667 
>  
>  @gsnedders @jgraham PTAL.
>  
>  I don't quite actually understand the bug. Doesn't Python have GIL? It seems to me we have multiple `ports()` running at the same time modifying `self._computed_ports`. How's that possible?
>  
>  Regardless, this fix seems to work locally, although I don't know how to write a unit test for this.
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c07362c50c09
[wpt PR 10723] - Attempt to make Config.ports() thread-safe, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/15aeca73863d
[wpt PR 10723] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/c07362c50c09
https://hg.mozilla.org/mozilla-central/rev/15aeca73863d
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.