Implement Search (button that loads search.netscape.com)

VERIFIED FIXED

Status

Camino Graveyard
General
VERIFIED FIXED
16 years ago
16 years ago

People

(Reporter: Winnie Lam, Assigned: Simon Fraser)

Tracking

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Reporter)

Description

16 years ago
Implement Search ( button that loads search.netscape.com).
(Reporter)

Updated

16 years ago
Blocks: 145820
(Reporter)

Updated

16 years ago
QA Contact: petersen → winnie
Summary: Implement Search ( button that loads search.netscape.com) → Implement Search ( button that loads search.netscape.com)

Comment 1

16 years ago
I presume this will be user-settable to other search engines as is the case in
Mozilla...
Summary: Implement Search ( button that loads search.netscape.com) → Implement Search (button that loads search.netscape.com)

Comment 2

16 years ago
Should probably respect the System Preferences search page, as Chimera already
respects the home page from there?

Comment 3

16 years ago
->beard
Assignee: bnesse → beard

Comment 4

16 years ago
This has been implemented, although right now the button can only take you to
dmoz.org. Also, I saw in the CVS notes that Beard didn't have an icon for this
so he used the magnifying glass from the finder. We already have a Chimera-style
magnifying glass in the file download window's toolbar that we could use for
this. Since that window is going to be replaced, we don't have to worry about
using the same icon for two different things.

This could now be changed to an RFE to have the search button be customizable. I
noticed that there is an unimplemented drop down menu to change search engines
in the personal pref pane, but I would think we could just use the search page
from system prefs?

Comment 5

16 years ago
Taking this back so I can find it more easily. :)

Comment 6

16 years ago
Created attachment 88034 [details] [diff] [review]
Proposed patch

Patch to replace search image and connect the button to the users Internet
Config setting for search page.

Mike, Patrick, can one of you review this and check it in if it's ok? Thanks.

Comment 7

16 years ago
Really take it back...
Assignee: beard → bnesse

Comment 8

16 years ago
Created attachment 89308 [details] [diff] [review]
Revised patch

Revised patch according to branding requirements. Mike, can you r= and land?
Attachment #88034 - Attachment is obsolete: true
no, we should be reading this from a localized string that any commercial build
can replace. no netscape branding is allowed in the mozilla tree.

Comment 10

16 years ago
Created attachment 89600 [details] [diff] [review]
Yet another attempt

Here is a totally new approach. This allows us to force the search preference
by setting a preference in all.js

pref("search.default_engine","http://search.netscape.com/");

If this preference does not exist, we use the setting in InternetConfig.

Mike, it's in your court again. :)
Attachment #89308 - Attachment is obsolete: true

Comment 11

16 years ago
cc'ing sfraser for review, since pink has probably gone home
(Assignee)

Comment 12

16 years ago
In most places in the code, instead of:

+    nsCOMPtr<nsIPrefService>
prefs(do_GetService("@mozilla.org/preferences-service;1"));
+    if (prefs) {
+        nsCOMPtr<nsIPrefBranch> dirBranch;
+        prefs->GetBranch("", getter_AddRefs(dirBranch));


we just do

nsCOMPtr<nsIPrefBranch> prefs = do_GetService("@mozilla.org/preferences-service;1");

Why not here?

Comment 13

16 years ago
Created attachment 89630 [details] [diff] [review]
Patch v4

Version reflecting sfraser's comments.

Updated

16 years ago
Attachment #89600 - Attachment is obsolete: true
(Assignee)

Comment 14

16 years ago
Comment on attachment 89630 [details] [diff] [review]
Patch v4

r=sfraser
Attachment #89630 - Flags: review+

Comment 15

16 years ago
Simon, do you have checkin privileges for chimera? If so, can you land this?
Otherwise, Chris, who else can land this?
(Assignee)

Comment 16

16 years ago
I do, and I can.
Assignee: bnesse → sfraser
(Assignee)

Comment 17

16 years ago
Checked in for bnesse.
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
(Reporter)

Comment 18

16 years ago
verified with 07-02 build on OS 10.1.5.  clicking on the search button takes me
to the search.netscape.com page.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.