Closed
Bug 1458173
Opened 8 years ago
Closed 8 years ago
Fix some other TSan issues
Categories
(Core :: JavaScript Engine: JIT, enhancement)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(1 file)
|
4.17 KB,
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
This fixes most of the remaining issues I see when running jit-tests locally.
* We shouldn't check the addendumKind off-thread because it can race on the flags word, but fortunately we don't have to.
* MConstant::valueToBoolean calls EmulatesUndefined but that can race if the object has a lazy group and the main thread "delazifies". I don't think this particular optimization is very important (MTest/MNot can fold the object-input case anyway), so this patch removes the EmulatesUndefined call.
There's still a problem with the pre-barrier verifier, that one probably needs to cancel off-thread Ion compilations.
Attachment #8972257 -
Flags: review?(jcoppeard)
|
||
Comment 1•8 years ago
|
||
Comment on attachment 8972257 [details] [diff] [review]
Patch
Review of attachment 8972257 [details] [diff] [review]:
-----------------------------------------------------------------
Great, thanks for fixing this.
Attachment #8972257 -
Flags: review?(jcoppeard) → review+
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/daa8466df43e
Fix some issues reported by TSan. r=jonco
|
||
Comment 3•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•