14583 - If no key entered, next dialog does not make sense in context

Status: VERIFIED INVALID

(SeaMonkey :: Passwords & Permissions, defect, P3)

Description

[cpratt]

Build ID: 1999092208
Platform: all

To reproduce:
- Launch apprunner
- Go to a site with a login (eg my.netscape.com)
- Enter the info requested and send it to the server
- At this point wallet / single signon takes over. Eventually you are asked to
enter a key *OR* to leave the input field blank.

Result: If you opt to leave it blank, another dialog comes up that asks you to
'confirm your key'. Logically, you went for the OR condition of a key; that is,
NO key. Therefore, you can't confirm your key because you have no key. I would
instead expect this dialog to be skipped if you opted for NO key.

Comment 1

[Stephen P. Morse]

Although I agree with you, it could be argued that even the empty password
should be confirmed.  What if the user thought that he entered a
single-character password but his finger slipped and he didn't enter any
characters.  The confirmation would catch that error.

But it's all academic anyway.  The use of two dialog boxes (one asking for
password and the second asking for confirmation) is hopefully temporary.  It
will be dropped if davidm provides us with a single dialog containg two password
fields.

So based on these arguments, I am closing the bug report out as invalid.

Comment 2

[Paul MacQuiddy]

agreed, this will hopefully be a moot point

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/beccf82a3e0a
[fenix] FNX-14583 ⁃ Extract and test preference helpers for Settings (https://github.com/mozilla-mobile/fenix/pull/13402)