1458376 - <select> popups aren't visible inside the Payment Request dialog

Status: RESOLVED FIXED

(Firefox :: WebPayments UI, enhancement, P1)

Description

[Matthew N. [:MattN]]

The keyboard controls work but the popup is never shown.

Comment 1

[Matthew N. [:MattN]]

Some notes so far:
* The content process side seems to work at first glance. The Forms:ShowDropDown frame message is sent
* There is nothing listening for the message on the parent side because it's implemented in (remote-)browser.xml[1] for regular <xul:browser>s.
** Just switching to a <xul:browser> won't fix the issue as they have a @selectmenulist attribute which needs to point to a <xul:menulist> similar to #ContentSelectDropdown[2][3][4], see the comment there too. We could copy 

Notes to self:
* @forcemessagemanager=true on <browser> may resolve a previous issue with using <xul:browser>: https://dxr.mozilla.org/mozilla-central/rev/59005ba3cd3e7b3f9e8804bea881bf4c3a755d7c/toolkit/mozapps/extensions/content/extensions.js#3078
* @remoteType on <browser> may be useful for forcing a specific process type.

[1] https://dxr.mozilla.org/mozilla-central/rev/59005ba3cd3e7b3f9e8804bea881bf4c3a755d7c/toolkit/content/widgets/remote-browser.xml#482
[2] https://dxr.mozilla.org/mozilla-central/rev/59005ba3cd3e7b3f9e8804bea881bf4c3a755d7c/browser/base/content/browser.xul#194-206
[3] https://dxr.mozilla.org/mozilla-central/rev/59005ba3cd3e7b3f9e8804bea881bf4c3a755d7c/browser/base/content/webext-panels.xul#82-94
[4] https://dxr.mozilla.org/mozilla-central/rev/59005ba3cd3e7b3f9e8804bea881bf4c3a755d7c/toolkit/mozapps/extensions/content/extensions.js#3079

Comment 2

[Matthew N. [:MattN]]

Attachment: Bug 1458376 - Use a <xul:browser> to display the PaymentRequest UI to fix <select> dropdowns.

Review commit: https://reviewboard.mozilla.org/r/242524/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/242524/

Comment 3

[Matthew N. [:MattN]]

Attachment: Bug 1458376 - Convert PaymentRequest b-c tests to always test in the dialog.

This makes test check what we ship and makes them more consistent. It also avoids issues related to nested <xul:browser>.

Review commit: https://reviewboard.mozilla.org/r/243278/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/243278/

Comment 4

[Matthew N. [:MattN]]

Comment on attachment 8974228 [details]
Bug 1458376 - Use a <xul:browser> to display the PaymentRequest UI to fix <select> dropdowns.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/242524/diff/1-2/

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8974228 [details]
Bug 1458376 - Use a <xul:browser> to display the PaymentRequest UI to fix <select> dropdowns.

https://reviewboard.mozilla.org/r/242524/#review249370

r=me, but somewhat tentative about the issue below

::: browser/components/payments/content/paymentDialogWrapper.xul:21
(Diff revision 2)
> +         work correctly on the menupopup. ContentSelectDropdown expects the
> +         popuponly menulist to be its immediate parent. -->
> +    <menulist popuponly="true" id="ContentSelectDropdown" hidden="true">
> +      <menupopup rolluponmousewheel="true"
> +                 activateontab="true" position="after_start"
> +                 level="parent"

Why didn't you include the special attributes for Windows?

https://searchfox.org/mozilla-central/rev/babf96cf0c37b608e9663e2af73a4d21819c4af1/browser/base/content/browser.xul#202-204

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8974890 [details]
Bug 1458376 - Convert PaymentRequest b-c tests to always test in the dialog.

https://reviewboard.mozilla.org/r/243278/#review249378

Comment 7

[Matthew N. [:MattN]]

Comment on attachment 8974890 [details]
Bug 1458376 - Convert PaymentRequest b-c tests to always test in the dialog.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/243278/diff/1-2/

Comment 8

[Matthew N. [:MattN]]

Comment on attachment 8974228 [details]
Bug 1458376 - Use a <xul:browser> to display the PaymentRequest UI to fix <select> dropdowns.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/242524/diff/2-3/

Comment 9

[Matthew N. [:MattN]]

Comment on attachment 8974228 [details]
Bug 1458376 - Use a <xul:browser> to display the PaymentRequest UI to fix <select> dropdowns.

https://reviewboard.mozilla.org/r/242524/#review249370

> Why didn't you include the special attributes for Windows?
> 
> https://searchfox.org/mozilla-central/rev/babf96cf0c37b608e9663e2af73a4d21819c4af1/browser/base/content/browser.xul#202-204

I didn't want to use pre-processing and wasn't sure dynamic popup switching would work… I also planned to fix it later when I tested on Windows.… turns out not having the attributes was the reason for the test failure :P Dynamic switching at runtime seems to work too!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b0d105ef54cd
Convert PaymentRequest b-c tests to always test in the dialog. r=jaws
https://hg.mozilla.org/integration/autoland/rev/cc9b55f105bb
Use a <xul:browser> to display the PaymentRequest UI to fix <select> dropdowns. r=jaws

Comment 11

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/b0d105ef54cd
https://hg.mozilla.org/mozilla-central/rev/cc9b55f105bb