Closed Bug 1458386 Opened 2 years ago Closed 2 years ago

Make mach run aware of launcher process

Categories

(Firefox Build System :: General, defect, P1)

Unspecified
Windows
defect

Tracking

(firefox61 wontfix, firefox62 wontfix, firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox61 --- wontfix
firefox62 --- wontfix
firefox63 --- fixed

People

(Reporter: aklotz, Assigned: aklotz)

References

(Blocks 1 open bug)

Details

(Whiteboard: inj+)

Attachments

(1 file)

We'd need to make the bootstrap process WaitForSingleObject on the browser process.
Priority: P2 → P3
The Firefox side of this was taken care of in bug 1481635.

For mach run itself, it should pass -wait-for-browser to the browser when MOZ_LAUNCHER_PROCESS is set in the config.

This is because, by default, the launcher process terminates after successfully starting the browser process. mach run's current expectation is that its child process remains alive for the lifetime of the browser (under the assumption that mach's child process is the browser process itself).

We can force the launcher process to emulate this by passing -wait-for-browser.
Assignee: nobody → aklotz
Status: NEW → ASSIGNED
Depends on: 1481635, 1481549
Priority: P3 → P1
Product: Firefox → Firefox Build System
Summary: mach run broken by bootstrap process → Make mach run aware of launcher process
Attachment #9000020 - Flags: review?(core-build-config-reviews)
Attachment #9000020 - Flags: review?(core-build-config-reviews) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/c7bea57cb29c6fb6175151c5277cdef30dcd67a9
Bug 1458386: Modify mach's RunProgram command provider to be aware of launcher process; r=gps
https://hg.mozilla.org/mozilla-central/rev/c7bea57cb29c
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.