Status

()

defect
P3
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: is2ei, Assigned: is2ei, Mentored)

Tracking

59 Branch
mozilla61
Points:
---

Firefox Tracking Flags

(firefox61 fixed)

Details

(Whiteboard: [good first bug])

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

a year ago
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0
Build ID: 20180326160923

Steps to reproduce:

Read source code.


Actual results:

Type in these files.
- toolkit/components/telemetry/tests/python/test_histogramtools_non_strict.py
- toolkit/components/telemetry/tests/python/test_histogramtools_non_strict.py

Typo is "	# file, You can obtain one at http://mozilla.org/MPL/2.0/.import json".

https://searchfox.org/mozilla-central/search?q=MPL%2F2.0%2F.import+json&case=true&regexp=false&path=




Expected results:

Typo needs to be fixed.

Updated

a year ago
Component: Untriaged → Telemetry
Product: Firefox → Toolkit
Mentor: jrediger
Whiteboard: [good first bug]
Assignee

Comment 1

a year ago
Hi, I'm Issei.

Could I work on this issue?
Flags: needinfo?(jrediger)
@Issei: Yes, please work on this. As you reported this I guess you already know what to do.
Flags: needinfo?(jrediger)
Assignee: nobody → is2ei.horie
Priority: -- → P3
Assignee

Comment 3

a year ago
Posted patch bug-1458398.patch (obsolete) — Splinter Review
I attached a patch. Could you review it?
Attachment #8972607 - Flags: review?(jrediger)
That looks good. Can you do me the favor and change the commit messages to describe what was done, e.g. "Fix typo in License URL"?
Flags: needinfo?(is2ei.horie)
Attachment #8972607 - Flags: review?(jrediger) → review-
Assignee

Comment 5

a year ago
Thanks! I've edited the comment.
Could you check it, please? Thanks.
Flags: needinfo?(is2ei.horie)
Attachment #8972744 - Flags: review?(jrediger)

Updated

a year ago
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #8972744 - Flags: review?(jrediger) → review+
Attachment #8972607 - Attachment is obsolete: true
Perfect!
Keywords: checkin-needed

Comment 8

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9fa0acb5980e
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.