Closed Bug 1458417 Opened 7 years ago Closed 3 months ago

Rusttests task don't need to build the whole Gecko

Categories

(Firefox Build System :: General, enhancement)

Product:
Firefox Build System
Component:
General
Version:
3 Branch
Type:
enhancement

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: xidorn, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: in-triage)

I believe that we can avoid building majority of stuff in rusttests task. We just need to finish export phase so that headers are copied to dist and the build script of style crate can use the, and after that it should be safe to execute force-cargo-test-run to run the tests. That should save lots of machine time.
Keywords: in-triage
Keywords: in-triage
Version: Version 3 → 3 Branch
Severity: normal → S3

I'm pretty sure this is true now. The current rusttests command only depends on the configure and export phases:
https://searchfox.org/mozilla-central/rev/6c0885bd353e783a6b7009640e6d5b4f8e235c8e/testing/mach_commands.py#1129.

Should we mark this fixed?

Note: for https://bugzilla.mozilla.org/show_bug.cgi?id=1958000, we might end up decided to reverse this and do a full build. However, I'm not sure about that and I think we can close this one regardless.

Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.