cygwin32 and bootstrap.pl

VERIFIED FIXED

Status

()

Core
Embedding: APIs
VERIFIED FIXED
16 years ago
16 years ago

People

(Reporter: Garrett Arch Blythe, Assigned: Garrett Arch Blythe)

Tracking

Trunk
x86
Windows 2000
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

2.10 KB, patch
hacker formerly known as seawood@netscape.com
: review+
Details | Diff | Splinter Review
(Assignee)

Description

16 years ago
bootstrap.pl did not work under my cygwin build environment.
have no idea if boostrap.pl or our build system works without cygwin.
(Assignee)

Comment 1

16 years ago
Created attachment 84372 [details] [diff] [review]
patch to switch make command.

Makes bootstrap.pl work under my build environment.
(Assignee)

Comment 2

16 years ago
need simple review buyoff on this.
Status: NEW → ASSIGNED
Comment on attachment 84372 [details] [diff] [review]
patch to switch make command.

r=cls
Attachment #84372 - Flags: review+
(Assignee)

Comment 4

16 years ago
cvs commit: Examining .
Checking in bootstrap.pl;
/cvsroot/mozilla/tools/module-deps/bootstrap.pl,v  <--  bootstrap.pl
new revision: 1.27; previous revision: 1.26
done
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Comment 5

16 years ago
I think we should default to "make" unless we're in an unusual environment (like
HP or AIX or whichever platform has a non-gnu make by default)

Updated

16 years ago
QA Contact: mdunn → depstein
(Assignee)

Comment 6

16 years ago
reopen to change to use "make" only.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
I think the majority of the platforms default to a non-gnu version of make so we
should use gmake by default.  IIRC, the count goes:

GNU make               Non-GNU make
---------              -------------
Linux                    FreeBSD
BeOS                     NetBSD
win32/cygwin             OpenBSD
OSX/Darwin               AIX
OS2/emx                  HP-UX
                         Solaris
                         IRIX
                         OSF/1
                         BSDI

OpenVMS?
SCO?
Unixware?
(Assignee)

Comment 8

16 years ago
Okay, this is good data that I had no idea about, thx seawood.
I think we just leave it and special case others if the need arises like I did
for cygwin.

garrett
Status: REOPENED → RESOLVED
Last Resolved: 16 years ago16 years ago
Resolution: --- → FIXED

Comment 9

16 years ago
'gmake' replaced by makecmd variable in bootstrap.pl. system("$makecmd
export-idl") now added in.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.