1458458 - Cleanup a bit nsDOMCSSAttributeDeclaration.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Emilio Cobos Álvarez (:emilio)]

In preparation of removing the serialization roundtrip that SMIL does, which is blocking bug 1457353.

After this we can use Uncompute instead of nsSMILCSSValueType in order to avoid trying to serialize complex colors.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1458458: Cleanup a bit nsDOMCSSAttrDeclaration.

In preparation of removing the serialization roundtrip that SMIL does, which is
blocking bug 1457353.

Move the SMIL code in there, since we're going to mess with it more in a second.

After this we can use Uncompute instead of nsSMILCSSValueType in order to avoid
trying to serialize complex colors.

Review commit: https://reviewboard.mozilla.org/r/241100/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/241100/

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8972512 [details]
Bug 1458458: Cleanup a bit nsDOMCSSAttrDeclaration.

https://reviewboard.mozilla.org/r/241100/#review246886

Looks good to me basically but we should split dropping the code for the old style stuff into a separate patch.

::: dom/smil/nsSMILCSSProperty.cpp:110
(Diff revision 1)
>  
>  nsresult
>  nsSMILCSSProperty::SetAnimValue(const nsSMILValue& aValue)
>  {
>    NS_ENSURE_TRUE(IsPropertyAnimatable(mPropID), NS_ERROR_FAILURE);
> -
> +  return mElement->GetSMILOverrideStyle()->SetSMILValue(mPropID, aValue);

I am not concinved we can ensure that GetSMILOverriderStyle() doesn't return nullptr here.  Are you?

Comment 3

[Emilio Cobos Álvarez (:emilio)]

It creates the declaration if it doesn't exist, so yeah, can't return null:

  https://searchfox.org/mozilla-central/rev/795575287259a370d00518098472eaa5b362bfa7/dom/base/Element.cpp#2051

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b54012d35b8d
Remove dead code from nsDOMCSSAttributeDeclaration. r=hiro
https://hg.mozilla.org/integration/mozilla-inbound/rev/8ee81dec09bd
Minor nsDOMCSSAttrDeclaration cleanup. r=hiro
https://hg.mozilla.org/integration/mozilla-inbound/rev/bb5befa3fdba
Move setting SMIL override values into nsDOMCSSAttrDeclaration. r=hiro

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/b54012d35b8d
https://hg.mozilla.org/mozilla-central/rev/8ee81dec09bd
https://hg.mozilla.org/mozilla-central/rev/bb5befa3fdba