1458489 - Firefox RC: Missing beta / beta-cdntest entries

Status: RESOLVED FIXED

(Release Engineering :: General, enhancement)

Description

[Simon Fraser [:sfraser] ⌚️GMT]

The balrog entries for the Firefox-60.0build1 release blob didn't get created with beta or beta-cdntest entries, and they had to be manually added.

Comment 1

[Simon Fraser [:sfraser] ⌚️GMT]

release-secondary-balrog-submit-toplevel-firefox was told to submit beta-cdntest entries
https://tools.taskcluster.net/groups/aB3RQPVESoyWn86O5BHdpg/tasks/JqwHaesiTreG3j5dHVL9XA/runs/0/logs/public%2Flogs%2Flive_backing.log

But the logs aren't entirely clear about what it was asking to do - the HEAD request is there indicating there was a non-GET request and it wanted a CRSF token, but not a log of the changes requested.

The associated history update in balrog for Firefox-60.0-build1 seems to be 492, where it only did this (aliasses and OSBOUNCER/FTP stripped):

--- Data Version 491
+++ Data Version 492
@@ -1,8 +1,43 @@
 {
+  "appVersion": "60.0",
+  "displayVersion": "60.0",
+  "fileUrls": {
+    "*": {
+      "completes": {
+        "*": "http://download.mozilla.org/?product=firefox-60.0-complete&os=%OS_BOUNCER%&lang=%LOCALE%"
+      },
+      "partials": {
+        "Firefox-59.0.2-build1": "http://download.mozilla.org/?product=firefox-60.0-partial-59.0.2&os=%OS_BOUNCER%&lang=%LOCALE%",
+        "Firefox-59.0.3-build1": "http://download.mozilla.org/?product=firefox-60.0-partial-59.0.3&os=%OS_BOUNCER%&lang=%LOCALE%",
+        "Firefox-60.0b16-build1": "http://download.mozilla.org/?product=firefox-60.0-partial-60.0b16&os=%OS_BOUNCER%&lang=%LOCALE%"
+      }
+    },
+    "beta-localtest": {
+      "completes": {
+        "*": "http://archive.mozilla.org/pub/firefox/candidates/60.0-candidates/build1/update/%OS_FTP%/%LOCALE%/firefox-60.0.complete.mar"
+      },
+      "partials": {
+        "Firefox-59.0.2-build1": "http://archive.mozilla.org/pub/firefox/candidates/60.0-candidates/build1/update/%OS_FTP%/%LOCALE%/firefox-59.0.2-60.0.partial.mar",
+        "Firefox-59.0.3-build1": "http://archive.mozilla.org/pub/firefox/candidates/60.0-candidates/build1/update/%OS_FTP%/%LOCALE%/firefox-59.0.3-60.0.partial.mar",
+        "Firefox-60.0b16-build1": "http://archive.mozilla.org/pub/firefox/candidates/60.0-candidates/build1/update/%OS_FTP%/%LOCALE%/firefox-60.0b16-60.0.partial.mar"
+      }
+    }

Comment 2

[Simon Fraser [:sfraser] ⌚️GMT]

:bhearsum has found the answer here! 

Thanks to the logic in https://github.com/mozilla/build-tools/blob/master/lib/python/balrog/submitter/cli.py#L204 
`if not requiresMirrors and c in ("beta", "beta-cdntest"):` beta and beta-cdntest won't be updated if requiresMirrors is set, and yet it is:
https://dxr.mozilla.org/mozilla-central/source/taskcluster/ci/release-secondary-balrog-submit-toplevel/kind.yml#26

Since it's only release candidates that use this kind, we can flip this boolean.

Comment 3

[Simon Fraser [:sfraser] ⌚️GMT]

Attachment: Bug 1458489 Avoid use of mirrors for beta and beta-cdntest release updates

Review commit: https://reviewboard.mozilla.org/r/241128/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/241128/

Comment 4

[[e-mail] (:bhearsum)]

Comment on attachment 8972535 [details]
Bug 1458489 Avoid use of mirrors for beta and beta-cdntest release updates

https://reviewboard.mozilla.org/r/241128/#review246946

Looks like I missed this during my original review in https://reviewboard.mozilla.org/r/220790/diff/11#index_header. I was trying to find proof that we used to set this to false for old style releases, but I can't find the right configs...but I'm sure this is correct!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/59c476da2440
Avoid use of mirrors for beta and beta-cdntest release updates r=bhearsum

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/59c476da2440

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr60/rev/7da8f85ea8e5

Comment 8

[Ryan VanderMeulen [:RyanVM]]

This landed on m-r too (prior to the ESR60 uplift in comment 7).
https://hg.mozilla.org/releases/mozilla-release/rev/7da8f85ea8e5