Closed
Bug 1458492
Opened 7 years ago
Closed 7 years ago
Uplift patches for correct popup window positions at ESR60 line.
Categories
(Core :: Widget: Gtk, enhancement)
Tracking
()
RESOLVED
FIXED
People
(Reporter: stransky, Assigned: stransky)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
|
24.26 KB,
patch
|
RyanVM
:
approval-mozilla-esr60+
|
Details | Diff | Splinter Review |
We'd need to uplift the following bugs to ESR60 line to fix wrong popup/child window positions when titlebar/csd mode is enabled:
https://bugzilla.mozilla.org/show_bug.cgi?id=1441873
https://bugzilla.mozilla.org/show_bug.cgi?id=1441665
https://bugzilla.mozilla.org/show_bug.cgi?id=1456898
https://bugzilla.mozilla.org/show_bug.cgi?id=1457309
https://bugzilla.mozilla.org/show_bug.cgi?id=1457691
| Assignee | ||
Updated•7 years ago
|
| Assignee | ||
Comment 1•7 years ago
|
||
There's all in one composed patch which can be checked in to ESR60 line.
| Assignee | ||
Updated•7 years ago
|
Attachment #8972526 -
Attachment description: complete-csd-window-offset patch → complete-csd-window-offset patch for Firefox 60
| Assignee | ||
Updated•7 years ago
|
Attachment #8972526 -
Flags: review?(jhorak)
Updated•7 years ago
|
Attachment #8972526 -
Flags: review?(jhorak) → review+
| Assignee | ||
Comment 3•7 years ago
|
||
[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration:
User impact if declined: Wrong popup position when titlebar is hiden and Firefox is running in CSD mode.
Fix Landed on Version: 61.0
Risk to taking this patch (and alternatives if risky): Low, it was verified at nightly.
String or UUID changes made by this patch: none
See https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for more info.
Flags: needinfo?(stransky)
Attachment #8984821 -
Flags: approval-mozilla-esr60?
Updated•7 years ago
|
Attachment #8972526 -
Attachment is obsolete: true
Comment 4•7 years ago
|
||
Comment on attachment 8984821 [details] [diff] [review]
window-csd-offset for check-in
Roll-up of various fixes for incorrect popup positions when the titlebar is hidden on Linux in CSD mode. Approved for ESR 60.1.
Attachment #8984821 -
Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
Comment 5•7 years ago
|
||
| uplift | ||
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•