1458557 - puppet often fails to install "cryptography" python module on the first try

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[[e-mail] (:bhearsum)]

I've seen this on a few different hosts when a virtualenv is rebuilt, the error is always:

May 02 08:30:11 buildduty-tools.srv.releng.usw2.mozilla.com puppet-agent: (/Stage[main]/Buildduty_tools::Builddutytools/Python::Virtualenv[/home/buildduty/buildduty-tools]/Python::Virtualenv::Package[/home/buildduty/buildduty-tools||cryptography==0.6]/Exec[pip /home/buildduty/buildduty-tools||cryptography==0.6]/returns) distutils.errors.DistutilsError: Could not find suitable distribution for Requirement.parse('six>=1.4.1') 

However, six is available, and gets installed after cryptography. On the next puppet run, cryptography ends up installing fine. I'm not sure if this is a problem with the pip version we're using, or something with Puppet.

Comment 1

[[e-mail] (:bhearsum)]

I did some looking into this, and it looks like this is an issue with one (or more) of setuptools, pip, virtualenv based on a read of https://github.com/pyca/cryptography/issues/1203. We're planning to upgrade those this quarter, so I don't think we need to do anything special for this right now.

Comment 2

[Aki Sasaki (not active)]

I bet we need to move those above cryptography in the module order. I pushed for an alphabetical sort, but we may want to go for a practical working sort.

Comment 3

[Aki Sasaki (not active)]

I may have fixed this in my multiple landings.

Comment 4

[[e-mail] (:bhearsum)]

This didn't end up blocking the Python upgrades.

Comment 5

[Aki Sasaki (not active)]

Attachment: cryptography.diff

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/build/puppet/rev/2d40e97c743f
reorder deps to fix cryptography first time install. r=bhearsum