Closed Bug 1458609 Opened 5 years ago Closed 5 years ago

Permafail devtools/client/webconsole/test/mochitest/browser_console_context_menu_entries.js when merged to beta

Categories

(DevTools :: Console, defect)

defect
Not set
normal

Tracking

(firefox-esr52 unaffected, firefox-esr60 unaffected, firefox59 unaffected, firefox60 unaffected, firefox61 verified)

VERIFIED FIXED
Firefox 61
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- unaffected
firefox59 --- unaffected
firefox60 --- unaffected
firefox61 --- verified

People

(Reporter: aryx, Assigned: nchevobbe)

References

Details

Attachments

(1 file)

Bug 1447235 was backed out and re-landed with a fix in the test today. The failures from Comment 0 seems to be the one that were fixed. Am I wrong ?
It's because the feature is behind an ifdef NIGHTLY_BUILD, but the test assumes the menu item is always present (= also on release or beta).
Assignee: aryx.bugmail → nchevobbe
Comment on attachment 8972635 [details]
Bug 1458609  - Fix browser_console_context_menu_entries; .

https://reviewboard.mozilla.org/r/241188/#review247092

::: devtools/client/webconsole/test/mochitest/browser_console_context_menu_entries.js:63
(Diff revision 1)
>  
>    await hideContextMenu(hud);
>  });
>  
> +function addNightlyOnlyEntries(expectedEntries) {
> +  let isNightly = AppConstants.NIGHTLY_BUILD;

Can you instead check the pref value (and then rename the function to something like `addSidebarEntry`)? Then this won't be tied to the current default pref values in nightly/release.
Attachment #8972635 - Flags: review?(bgrinstead) → review+
Bug 1447235 got backed out and will reland after the version increase to 62.
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → INVALID
Fixed by backout is a perfectly valid resolution for a bug :)
Status: RESOLVED → VERIFIED
Resolution: INVALID → FIXED
Target Milestone: --- → Firefox 61
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.