1458609 - Permafail devtools/client/webconsole/test/mochitest/browser_console_context_menu_entries.js when merged to beta

Status: VERIFIED FIXED

(DevTools :: Console, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

central-as-beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8859643fd6c00ddb1d0701298db10ca3f40c4624&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=runnable&selectedJob=176595415

This blocks our daily central-to-beta merges.

Regression from bug 1447235.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Bug 1447235 was backed out and re-landed with a fix in the test today. The failures from Comment 0 seems to be the one that were fixed. Am I wrong ?

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

It's because the feature is behind an ifdef NIGHTLY_BUILD, but the test assumes the menu item is always present (= also on release or beta).

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1458609 - Fix browser_console_context_menu_entries; .

The test is changed to take into account that the sidebar is still not
enabled in non-nightly build.

Review commit: https://reviewboard.mozilla.org/r/241188/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/241188/

Comment 4

[Brian Grinstead [:bgrins]]

Comment on attachment 8972635 [details]
Bug 1458609  - Fix browser_console_context_menu_entries; .

https://reviewboard.mozilla.org/r/241188/#review247092

::: devtools/client/webconsole/test/mochitest/browser_console_context_menu_entries.js:63
(Diff revision 1)
>  
>    await hideContextMenu(hud);
>  });
>  
> +function addNightlyOnlyEntries(expectedEntries) {
> +  let isNightly = AppConstants.NIGHTLY_BUILD;

Can you instead check the pref value (and then rename the function to something like `addSidebarEntry`)? Then this won't be tied to the current default pref values in nightly/release.

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8972635 [details]
Bug 1458609  - Fix browser_console_context_menu_entries; .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/241188/diff/1-2/

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Bug 1447235 got backed out and will reland after the version increase to 62.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Fixed by backout is a perfectly valid resolution for a bug :)