Closed Bug 1458621 Opened 2 years ago Closed 2 years ago

Error: Problem initializing top stories feed: Component returned failure code: 0x8000ffff (NS_ERROR_UNEX...

Categories

(Firefox :: New Tab Page, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 62
Iteration:
62.1 - May 21
Tracking Status
firefox61 --- wontfix
firefox62 --- fixed

People

(Reporter: dmose, Assigned: ursula)

References

()

Details

(Whiteboard: [nightly-js-sentry:4300705])

Attachments

(1 file)

This bug was automatically filed from Sentry: https://sentry.prod.mozaws.net/operations/nightly-js-errors/issues/4300705/

Error: Problem initializing top stories feed: Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIPrefBranch.getCharPref]
    at initFeed(resource://activity-stream/lib/TopStoriesFeed.jsm:61:9)
    at handler(resource://gre/modules/EventEmitter.jsm:95:34)
    at emit(resource://gre/modules/EventEmitter.jsm:150:11)
    at emit(self-hosted:983:17)
    at init(resource://activity-stream/lib/SectionsManager.jsm:118:5)
    at InterpretGeneratorResume(self-hosted:1264:8)
    at next(self-hosted:1219:9)
This seems to have happened exactly twice in the Nightly 1% ever.
Hm. So one problem is that `getCharPref()` throws if the pref in the first arg does not exist, *unless* you specify a second arg to use as the default:

https://searchfox.org/mozilla-central/rev/ce9ff94ffed34dc17ec0bfa406156d489eaa8ee1/browser/extensions/activity-stream/lib/TopStoriesFeed.jsm#263

https://searchfox.org/mozilla-central/rev/ce9ff94ffed34dc17ec0bfa406156d489eaa8ee1/modules/libpref/nsIPrefBranch.idl#104-105

The fact that the pref does not exist when the code expects it to is likely a different bug :) But at least it wouldn't throw here anymore.
The pref gets set from the pocket extension defined here:
https://searchfox.org/mozilla-central/rev/ce9ff94ffed34dc17ec0bfa406156d489eaa8ee1/browser/extensions/pocket/bootstrap.js#43

So activity stream is checking the pref before pocket runs.. or maybe the user has disabled the pocket add-on (different from disabling via browser.pocket.enabled) / prevented the extension from loading.
(In reply to Ed Lee :Mardak from comment #3)
> The pref gets set from the pocket extension defined here:
> https://searchfox.org/mozilla-central/rev/
> ce9ff94ffed34dc17ec0bfa406156d489eaa8ee1/browser/extensions/pocket/bootstrap.
> js#43
> 
> So activity stream is checking the pref before pocket runs.. or maybe the
> user has disabled the pocket add-on (different from disabling via
> browser.pocket.enabled) / prevented the extension from loading.

Oh, huh. Maybe that should be moved to a default pref in https://searchfox.org/mozilla-central/source/browser/app/profile/firefox.js? Inter-dependencies between built-in extensions is an anti-pattern IMHO...
Assignee: nobody → usarracini
Iteration: --- → 62.1 - May 21
Priority: -- → P1
Comment on attachment 8973792 [details]
Bug 1458621 - Move Pocket pref to firefox.js

https://reviewboard.mozilla.org/r/242156/#review249652

Looks good to me; thanks for the patch!  r=dmose
Attachment #8973792 - Flags: review?(dmose) → review+
Pushed by usarracini@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bd068af0ff3e
Move Pocket pref to firefox.js r=dmose
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f9a82afe632d
Move Pocket pref to firefox.js r=dmose
https://hg.mozilla.org/mozilla-central/rev/bd068af0ff3e
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
Is this something that can ride the trains or should we be considering it for Beta uplift?
Flags: needinfo?(usarracini)
In my opinion this can ride the trains and does not need to be uplifted to Beta. This very very rarely happens, as dmose mentioned the error has only ever happened twice.
Flags: needinfo?(usarracini)
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.