Closed
Bug 1458646
Opened 6 years ago
Closed 6 years ago
Replace JS_NewStringCopyZ with NewStringCopyZ in Intl code
Categories
(Core :: JavaScript: Standard Library, enhancement, P3)
Core
JavaScript: Standard Library
Tracking
()
RESOLVED
FIXED
mozilla62
People
(Reporter: anba, Assigned: anba)
Details
Attachments
(1 file)
|
5.25 KB,
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
JS-engine internal code should directly call NewStringCopyZ instead of going through jsapi's JS_NewStringCopyZ.
|
Assignee | |
Comment 1•6 years ago
|
||
Replaces JS_NewStringCopyZ with NewStringCopyZ in Intl code. Also reports an error if ICU returns nullptr instead of silently treating nullptr as requests to create an empty string <https://searchfox.org/mozilla-central/rev/795575287259a370d00518098472eaa5b362bfa7/js/src/jsapi.cpp#5782-5783>.
Attachment #8972659 -
Flags: review?(jwalden+bmo)
|
||
Updated•6 years ago
|
Attachment #8972659 -
Flags: review?(jwalden+bmo) → review+
|
|
Assignee | |
Comment 2•6 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2860bbcf47df304252da336a384ce9a4bbc3db02
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5f691b58a680 Replace JS_NewStringCopyZ with NewStringCopyZ in Intl code. r=Waldo
Keywords: checkin-needed
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/5f691b58a680
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
|
||
Updated•6 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•