Closed Bug 1458745 Opened Last year Closed Last year

Only get the notification box in the inspector for the debugger warning only if the debugger is paused.

Categories

(DevTools :: Inspector, enhancement, P3)

enhancement

Tracking

(firefox61 fixed)

RESOLVED FIXED
Firefox 61
Tracking Status
firefox61 --- fixed

People

(Reporter: gl, Assigned: gl)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

In https://searchfox.org/mozilla-central/source/devtools/client/inspector/inspector.js#243, updateDebuggerPausedWarning requires and renders the NotificationBox components, which isn't really necessary unless the debugger is paused. We can make this more lazy by only getting the NotificationBox if the debugger is paused.
Summary: Only show the debugger paused warning if the debugger is paused → Only get the notification box in the inspector for the debugger warning only if the debugger is paused.
Attachment #8972745 - Flags: review?(pbrosset)
Comment on attachment 8972745 [details]
Bug 1458745 - Only get the notification box in the inspector for the debugger warning only if the debugger is paused.

https://reviewboard.mozilla.org/r/241280/#review247176
Attachment #8972745 - Flags: review?(pbrosset) → review+
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4a2622e9e2b4
Only get the notification box in the inspector for the debugger warning only if the debugger is paused. r=pbro
Backed out changeset 4a2622e9e2b4 (bug 1458745) for DevTools Failures on devtools/client/shared/test/browser_telemetry_button_eyedropper.js. CLOSED TREE\

Log:
https://treeherder.mozilla.org/logviewer.html#?job_id=176776062&repo=mozilla-inbound&lineNumber=13680

  INFO - GECKO(1969) | --DOMWINDOW == 0 (0x12ea8cc00) [pid = 1969] [serial = 214] [outer = 0x0] [url = chrome://devtools/content/inspector/markup/markup.xhtml]
08:38:57     INFO - GECKO(1969) | nsStringStats
08:38:57     INFO - GECKO(1969) |  => mAllocCount:         498861
08:38:57     INFO - GECKO(1969) |  => mReallocCount:        28054
08:38:57     INFO - GECKO(1969) |  => mFreeCount:          498861
08:38:57     INFO - GECKO(1969) |  => mShareCount:         521196
08:38:57     INFO - GECKO(1969) |  => mAdoptCount:          13848
08:38:57     INFO - GECKO(1969) |  => mAdoptFreeCount:      13988
08:38:57     INFO - GECKO(1969) |  => Process ID: 1969, Thread ID: 140735235957504
08:38:57     INFO - TEST-INFO | Main app process: exit 0
08:38:57    ERROR - TEST-UNEXPECTED-FAIL | devtools/client/shared/test/browser_telemetry_button_eyedropper.js | leaked 4 window(s) until shutdown [url = about:blank]
08:38:57    ERROR - TEST-UNEXPECTED-FAIL | devtools/client/shared/test/browser_telemetry_button_eyedropper.js | leaked 2 window(s) until shutdown [url = chrome://devtools/content/inspector/markup/markup.xhtml]
08:38:57    ERROR - TEST-UNEXPECTED-FAIL | devtools/client/shared/test/browser_telemetry_button_eyedropper.js | leaked 1 window(s) until shutdown [url = chrome://devtools/content/inspector/inspector.xhtml]
08:38:57    ERROR - TEST-UNEXPECTED-FAIL | devtools/client/shared/test/browser_telemetry_button_eyedropper.js | leaked 1 window(s) until shutdown [url = about:devtools-toolbox]
08:38:57     INFO - TEST-INFO | devtools/client/shared/test/browser_telemetry_button_eyedropper.js | windows(s) leaked: [pid = 1969] [serial = 208], [pid = 1969] [serial = 205], [pid = 1969] [serial = 204], [pid = 1969] [serial = 207], [pid = 1969] [serial = 206], [pid = 1969] [serial = 215], [pid = 1969] [serial = 214], [pid = 1969] [serial = 213]
08:38:57     INFO - runtests.py | Application ran for: 0:03:30.632949
08:38:57     INFO - zombiecheck | Reading PID log: /var/folders/lj/tsq_n_0x3q5cb1v_sdjv248400000w/T/tmpAizQL4pidlog
08:38:57     INFO - ==> process 1969 launched child process 1970
08:38:57     INFO - ==> process 1969 launched child process 1971
08:38:57     INFO - ==> process 1969 launched child process 1972
08:38:57     INFO - ==> process 1969 launched child process 1973
08:38:57     INFO - ==> process 1969 launched child process 1974
08:38:57     INFO - zombiecheck | Checking for orphan process with PID: 1970
08:38:57     INFO - zombiecheck | Checking for orphan process with PID: 1971
08:38:57     INFO - zombiecheck | Checking for orphan process with PID: 1972
08:38:57     INFO - zombiecheck | Checking for orphan process with PID: 1973
08:38:57     INFO - zombiecheck | Checking for orphan process with PID: 1974
08:38:57     INFO - Stopping web server
08:38:57     INFO - Stopping web socket server
08:38:57     INFO - Stopping ssltunnel
08:38:57     INFO - TEST-INFO | leakcheck | default process: leak threshold set at 0 bytes
08:38:57     INFO - TEST-INFO | leakcheck | plugin process: leak threshold set at 0 bytes
08:38:57     INFO - TEST-INFO | leakcheck | tab process: leak threshold set at 0 bytes
08:38:57     INFO - TEST-INFO | leakcheck | geckomediaplugin process: leak threshold set at 20000 bytes
08:38:57     INFO - TEST-INFO | leakcheck | gpu process: leak threshold set at 0 bytes

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=4a2622e9e2b4f4ac42954c1f4e2f956468f202d9

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6654bf83bacc22d748dd36839fac488f75c3b77e
Flags: needinfo?(gl)
Flags: needinfo?(gl)
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/82c6cbd1db13
Only get the notification box in the inspector for the debugger warning only if the debugger is paused. r=pbro
https://hg.mozilla.org/mozilla-central/rev/82c6cbd1db13
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Blocks: 1462648
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.