Closed Bug 1458747 Opened 2 years ago Closed 2 years ago

Remove unused EventsView and ChangesView

Categories

(DevTools :: Inspector, enhancement, P3)

enhancement

Tracking

(firefox61 fixed)

RESOLVED FIXED
Firefox 61
Tracking Status
firefox61 --- fixed

People

(Reporter: gl, Assigned: gl)

Details

Attachments

(1 file)

No description provided.
Comment on attachment 8972746 [details]
Bug 1458747 - Remove unused EventsView and ChangesView.

https://reviewboard.mozilla.org/r/241284/#review247172
Attachment #8972746 - Flags: review?(pbrosset) → review+
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b755386490b9
Remove unused EventsView and ChangesView. r=pbro
Backed out changeset b755386490b9 (bug 1458747) for DevTools failure on devtools/client/shared/test/browser_telemetry_button_eyedropper.js. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#?job_id=176735157&repo=mozilla-inbound&lineNumber=13701

INFO - GECKO(1979) | nsStringStats
04:49:17     INFO - GECKO(1979) |  => mAllocCount:         499479
04:49:17     INFO - GECKO(1979) |  => mReallocCount:        28159
04:49:17     INFO - GECKO(1979) |  => mFreeCount:          499479
04:49:17     INFO - GECKO(1979) |  => mShareCount:         520915
04:49:17     INFO - GECKO(1979) |  => mAdoptCount:          13990
04:49:17     INFO - GECKO(1979) |  => mAdoptFreeCount:      14130
04:49:17     INFO - GECKO(1979) |  => Process ID: 1979, Thread ID: 140735216980736
04:49:17     INFO - TEST-INFO | Main app process: exit 0
04:49:17    ERROR - TEST-UNEXPECTED-FAIL | devtools/client/shared/test/browser_telemetry_button_eyedropper.js | leaked 4 window(s) until shutdown [url = about:blank]
04:49:17    ERROR - TEST-UNEXPECTED-FAIL | devtools/client/shared/test/browser_telemetry_button_eyedropper.js | leaked 2 window(s) until shutdown [url = chrome://devtools/content/inspector/markup/markup.xhtml]
04:49:17    ERROR - TEST-UNEXPECTED-FAIL | devtools/client/shared/test/browser_telemetry_button_eyedropper.js | leaked 1 window(s) until shutdown [url = about:devtools-toolbox]
04:49:17    ERROR - TEST-UNEXPECTED-FAIL | devtools/client/shared/test/browser_telemetry_button_eyedropper.js | leaked 1 window(s) until shutdown [url = chrome://devtools/content/inspector/inspector.xhtml]
04:49:17     INFO - TEST-INFO | devtools/client/shared/test/browser_telemetry_button_eyedropper.js | windows(s) leaked: [pid = 1979] [serial = 205], [pid = 1979] [serial = 208], [pid = 1979] [serial = 213], [pid = 1979] [serial = 206], [pid = 1979] [serial = 207], [pid = 1979] [serial = 215], [pid = 1979] [serial = 214], [pid = 1979] [serial = 204]
04:49:17     INFO - runtests.py | Application ran for: 0:03:31.972963
04:49:17     INFO - zombiecheck | Reading PID log: /var/folders/5x/hy18w5cs4p72fc69pxk469hm00000w/T/tmpkrKQ5tpidlog
04:49:17     INFO - ==> process 1979 launched child process 1980
04:49:17     INFO - ==> process 1979 launched child process 1981
04:49:17     INFO - ==> process 1979 launched child process 1982
04:49:17     INFO - ==> process 1979 launched child process 1983
04:49:17     INFO - ==> process 1979 launched child process 1984
04:49:17     INFO - zombiecheck | Checking for orphan process with PID: 1984
04:49:17     INFO - zombiecheck | Checking for orphan process with PID: 1980
04:49:17     INFO - zombiecheck | Checking for orphan process with PID: 1981
04:49:17     INFO - zombiecheck | Checking for orphan process with PID: 1982
04:49:17     INFO - zombiecheck | Checking for orphan process with PID: 1983
04:49:17     INFO - Stopping web server
04:49:17     INFO - Stopping web socket server
04:49:17     INFO - Stopping ssltunnel
04:49:17     INFO - TEST-INFO | leakcheck | default process: leak threshold set at 0 bytes
04:49:17     INFO - TEST-INFO | leakcheck | plugin process: leak threshold set at 0 bytes
04:49:17     INFO - TEST-INFO | leakcheck | tab process: leak threshold set at 0 bytes
04:49:17     INFO - TEST-INFO | leakcheck | geckomediaplugin process: leak threshold set at 20000 bytes
04:49:17     INFO - TEST-INFO | leakcheck | gpu process: leak threshold set at 0 bytes

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=b755386490b9bb8223e7e4809f7ec7b4f19b5718

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d31412f16a07e40f8d8747ce9a4cfcc314f53d70
Flags: needinfo?(gl)
Flags: needinfo?(gl)
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2550daee45e7
Remove unused EventsView and ChangesView. r=pbro
https://hg.mozilla.org/mozilla-central/rev/2550daee45e7
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.