1458762 - When disconnecting the account a message to reconnect is displayed

Status: NEW

(Firefox :: Sync, defect, P3)

Description

[Vlad Filippov (:vladikoff)]

Attachment: repro.gif

Platforms: Win 10x64, Android 7.1.1;
Staging server [train 110] and production.
Prerequisite: the user is logged with an account.

Steps to reproduce:
1.Go to hamburger menu and tap on account name;
2. Tap on Disconnect -> Disconnect and observe the behavior.

Actual results: After the account is disconnected the message "please sign in to reconnect account x" with a yellow sign is displayed for 2-3 seconds.

Expected results: no message is displayed after the account is disconnected.

Comment 1

[Vlad Filippov (:vladikoff)]

This is from https://github.com/mozilla/fxa-content-server/issues/6093

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Yeah, there's a bit of a race condition that's not immediately clear how to fix:

* I personally saw a case where, for some unknown reason, signedInUser.json ended up corrupt in a profile. FxA logged some warnings, but the UI acted as though Sync was never configured. In bug 1407116, this changed so that if we noticed Sync was configured but FxA thought noone was logged in, we entered a "please reauthenticate" state so at least the user noticed that Sync was no longer working.

* This had the side-effect described here - we disconnect FxA before resetting Sync - which ends up meaning that for the period in between these 2 steps the "needs reauth" state is shown. The delay is probably due to the fact that Sync attempts to delete some server data for the client.

I suspect it's possible to disconnect Sync before we disconnect FxA which sounds like it should fix it.