Closed Bug 1458836 Opened 3 years ago Closed 3 years ago

No needs to inform WorkerHolders when in Closing state

Categories

(Core :: DOM: Workers, enhancement, P2)

58 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: baku, Assigned: baku)

Details

Attachments

(1 file)

Finally, we removed all the uses of WorkerStatus 'Closing' state in our code base.
This means that APIs/components start the shutdown only when JS code stops to be executed on the worker-thread.

There were several bugs related to how APIs behaved after a self.close() call in workers. But they are all (?) fixed. Next step is to stop to notify WorkerHolders when the worker is in Closing state. Closing state is now just an internal state, not exposed. Note that we already have other 'internal' states: Pending and Running.
Attachment #8972830 - Flags: review?(bkelly)
Priority: -- → P2
Comment on attachment 8972830 [details] [diff] [review]
worker_closing.patch

Review of attachment 8972830 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with one addition.  Please make WorkerHolder::HoldWorker() return failure if someone passes Closing for the aFailStatus.  You could maybe assert that doesn't happen as well, but the API supports a runtime check easily enough.
Attachment #8972830 - Flags: review?(bkelly) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e73e0231a9e3
No needs to inform WorkerHolders when in Closing state, r=bkelly
https://hg.mozilla.org/mozilla-central/rev/e73e0231a9e3
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Depends on: 1459443
No longer depends on: 1459443
You need to log in before you can comment on or make changes to this bug.