1458854 - release_eta for firefox rc build shouldn't be used for firefox-beta rule update

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect)

Description

[Julien Cristau [:jcristau]]

I started Firefox 60.0 build1 with ETA set to May 9 at 15:00 UTC (should have been 13:00 but nevermind).  That date was used for the scheduled change to the firefox-beta rule when pushing the RC build to beta.  That would previously (and I think should still) have been scheduled for "ASAP", only using the ETA for the actual firefox-release rule change.

Comment 2

[Simon Fraser [:sfraser] ⌚️GMT]

This should be in the release-secondary-balrog-scheduling task, ignoring release_eta and setting it blank

Comment 3

[Phabricator Automation]

Attachment: Bug 1458854 Disable release_eta for rc on beta channel r=bhearsum

In essence, we're allowing a new field in the task definition,
which is trusted over the one that's passed in with the config. This
wouldn't make much sense if it had a real date in, but allows us to
set an empty string for the kind that needs it

Comment 4

[Phabricator Automation]

Comment on attachment 8974045 [details]
Bug 1458854 Disable release_eta for rc on beta channel r=bhearsum

Ben Hearsum (:bhearsum) has approved the revision.

https://phabricator.services.mozilla.com/D1214

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d95009513f9d
Disable release_eta for rc on beta channel r=bhearsum

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d95009513f9d

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d95009513f9d

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e4bae2bdbb13