Closed Bug 1458859 Opened 6 years ago Closed 6 years ago

Turn off stylo-disabled tests on ESR60

Categories

(Firefox Build System :: Task Configuration, task)

Product:
Firefox Build System
Component:
Task Configuration
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(firefox-esr60 fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox-esr60 --- fixed

People

(Reporter: RyanVM, Assigned: kmoir)

References

Details

Attachments

(2 files, 1 obsolete file)

builder diff
20.13 KB, text/plain
Details
bug1458859-2.patch
11.81 KB, patch
mtabara
: review+
RyanVM
: approval-mozilla-esr60+
Details | Diff | Splinter Review 
Stylo is the only supported CSS engine on ESR60. Let's turn off the stylo-disabled tests there to save resources and avoid extraneous oranges.
Component: General → Task Configuration
Product: Taskcluster → Firefox Build System
Kim, is there someone who can pick this up? Will save us wasted time and money if we do.
Flags: needinfo?(kmoir)
Assignee: nobody → kmoir
Flags: needinfo?(kmoir)
Let me take a look, since I believe I enabled them, I think it should be easy to revert the change.  If it takes to long, I'll redirect this bug to releng, it's not really a build system bug.
Attached patch bug1458859.patch (obsolete) — — Splinter Review 

    
    

    
  

      
      
      
      

        Attached file
          
        builder diff
        — 
      

    


  

    
  

        Attachment #8982229 -
        Attachment is patch: false

    
    

    
  


  
address linting error on try run

        Attachment #8982227 -
        Attachment is obsolete: true

    
  

        Attachment #8982264 -
        Flags: review?(mtabara)

    
    

    
  
Comment on attachment 8982264 [details] [diff] [review]
bug1458859-2.patch

LGTM! ++ for saving resources and $$

        Attachment #8982264 -
        Flags: review?(mtabara) → review+

    
    

    
  
Comment on attachment 8982264 [details] [diff] [review]
bug1458859-2.patch

[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration:
User impact if declined: none
Fix Landed on Version: esr60
Risk to taking this patch (and alternatives if risky): no risk, just reduces tests run to save $$
String or UUID changes made by this patch: no none

See https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for more info.

        Attachment #8982264 -
        Flags: approval-mozilla-esr60?

    
    

    
  
Comment on attachment 8982264 [details] [diff] [review]
bug1458859-2.patch

Approved, thanks!

        Attachment #8982264 -
        Flags: approval-mozilla-esr60? → approval-mozilla-esr60+

    
  
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED

    
  
Blocks: 1475076

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: