1458897 - svn revert in build-clang does not revert

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

svn revert requires a path, and does not take a revision.  This isn't an issue on build machines because we do a fresh checkout every time.

But if you're trying to run build-clang locally, with existing checkouts, it will:
1) successfully svn update
2) run svn revert, saying "Skipped <rev>" (except you don't see it because of -q
3) svn revert returns a successfull eror code
4) patch fails because the file was never reverted and it attempts to re-apply the patch

Also I think the revert command needs to come first.

Comment 1

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1458897 Fix svn revert in build-clang so one can re-run it successfully

svn revert requires a path, and does not take a revision.  This isn't an
issue on build machines because we do a fresh checkout every time.

But if you're trying to run build-clang locally, with existing checkouts,
it will:
1) successfully svn update
2) run svn revert, saying "Skipped <rev>"
      (except you don't see it because of -q)
3) svn revert returns a successfull eror code
4) patch fails because the file was never reverted and it attempts
   to re-apply the patch

Also I think the revert command needs to come first.

Review commit: https://reviewboard.mozilla.org/r/241428/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/241428/

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8972874 [details]
Bug 1458897 Fix svn revert in build-clang so one can re-run it successfully

https://reviewboard.mozilla.org/r/241428/#review248086

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/362c5d31459a
Fix svn revert in build-clang so one can re-run it successfully r=glandium

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/362c5d31459a