Closed Bug 1458928 Opened 6 years ago Closed 6 years ago

Remove dead CSSParserEnvironment code.

Categories

(Core :: CSS Parsing and Computation, enhancement)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla61
Tracking Flags:
Tracking Status
firefox61 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(1 file)

Bug 1458928: Remove GetCSSParsingEnvironment.
59 bytes, text/x-review-board-request
xidorn
: review+
Details 
      No description provided.
Comment on attachment 8972907 [details]
Bug 1458928: Remove GetCSSParsingEnvironment.

https://reviewboard.mozilla.org/r/241456/#review247420

Maybe we can simplify the naming of `ServoCSSParsingEnvironment` in a followup. Probably just call it `ParsingEnvironment` is enough, and `GetParsingEnvironment` for the method...
Attachment #8972907 - Flags: review?(xidorn+moz) → review+
(In reply to Xidorn Quan [:xidorn] UTC+10 from comment #2)
> Comment on attachment 8972907 [details]
> Bug 1458928: Remove GetCSSParsingEnvironment.
> 
> https://reviewboard.mozilla.org/r/241456/#review247420
> 
> Maybe we can simplify the naming of `ServoCSSParsingEnvironment` in a
> followup. Probably just call it `ParsingEnvironment` is enough, and
> `GetParsingEnvironment` for the method...

Yeah... We can probably unify naming with ServoCSSParser and such...
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/8b5bfccc85b1
Remove GetCSSParsingEnvironment. r=xidorn
Blocks: 1459111
https://hg.mozilla.org/mozilla-central/rev/8b5bfccc85b1
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.