Closed
Bug 1458953
Opened 7 years ago
Closed 7 years ago
remove a noisy service worker warning
Categories
(Core :: DOM: Service Workers, enhancement, P3)
Core
DOM: Service Workers
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: bkelly, Assigned: bkelly)
Details
Attachments
(1 file)
|
889 bytes,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
This warning is triggering a lot:
https://searchfox.org/mozilla-central/rev/ce9ff94ffed34dc17ec0bfa406156d489eaa8ee1/dom/serviceworkers/ServiceWorkerRegistrationImpl.cpp#934
It happens a lot more now that we always create the ServiceWorkerRegistration object eagerly in the service worker context. Its fine if this fails to dispatch since the worker shutting down does all the cleanup we need.
Updated•7 years ago
|
Priority: -- → P3
| Assignee | ||
Comment 1•7 years ago
|
||
Silence an overly verbose warning that happens pretty often.
Attachment #8973031 -
Flags: review?(amarchesini)
Updated•7 years ago
|
Attachment #8973031 -
Flags: review?(amarchesini) → review+
Pushed by bkelly@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f6cb88fc621f
Remove a verbose warning from ServiceWorkerRegistrationImpl. r=baku
Comment 3•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•