1458973 - Rename {Rooted,Handle}ScriptSource to {Rooted,Handle}ScriptSourceObject.

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Tooru Fujisawa [:arai]]

We have ScriptSource and ScriptSourceObject classes, and the definition of {Rooted,Handle}ScriptSource is really confusing.

> typedef JS::Rooted<ScriptSourceObject*>     RootedScriptSource;
> typedef JS::Handle<ScriptSourceObject*>     HandleScriptSource;

they should be renamed to {Rooted,Handle}ScriptSourceObject, to clarify it's ScriptSourceObject, not ScriptSource.

(of course, ScriptSource is not GC thing and won't be rooted, but...)

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Rename {Rooted,Handle}ScriptSource to {Rooted,Handle}ScriptSourceObject.

Comment 2

[Jim Blandy :jimb]

(In reply to Tooru Fujisawa [:arai] from comment #0)
> (of course, ScriptSource is not GC thing and won't be rooted, but...)

I think Rooted can be applied to anything with a `GCPolicy` specialization, which is not restricted to GC things, so it's not immediately obvious that Rooted<ScriptSource*> isn't a thing you can do.

Comment 3

[Jim Blandy :jimb]

Comment on attachment 8972972 [details] [diff] [review]
Rename {Rooted,Handle}ScriptSource to {Rooted,Handle}ScriptSourceObject.

Review of attachment 8972972 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you very much!

Comment 4

[Tooru Fujisawa [:arai]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4dc436553912f37245271228859ca880da76b335
Bug 1458973 - Rename {Rooted,Handle}ScriptSource to {Rooted,Handle}ScriptSourceObject. r=jimb

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/4dc436553912