1459041 - [wpt-sync] Sync PR 10830 - Move AudioBufferSourceNode tests to WPT

Status: RESOLVED FIXED

(Core :: Web Audio, enhancement, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 10830 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/10830
Details from upstream follow.

Raymond Toy <[e-mail]> wrote:
>  Move AudioBufferSourceNode tests to WPT
>  
>  These tests basically pass on Firefox.  If they don't, it's because
>  Firefox is incorrect and issues have been filed for these.
>  
>  During the testing, two mistakes in the tests were found.
>  
>  One is that we incorrectly handled some promises and the task wasn't
>  waiting for everything to finish.
>  
>  The second was an incorrect assumption that calling start() would
>  work.  Because of test failures in Firefox, this assumption is
>  incorrect.
>  
>  Updated audit.js to latest Chrome version (to get loadFileFromURL) and
>  add wpt lint exception for a console message in audit.js.
>  
>  Bug: 745778
>  Change-Id: I5f9ee01498678db0feb57051f682772ca7bd9fbb
>  Reviewed-on: https://chromium-review.googlesource.com/1040865
>  WPT-Export-Revision: 51e56aef72b5a473c7a075610e6a21ecbfd2c9ae

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=ff459ef13ce1c46a66220cc7751a7ee84f45def6

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=3e8cc7ea0f7599ec7375adfd2f3a529989dd9293

Comment 3

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

PR 10830 applied with additional changes from upstream: 46fe6803fdd163e21137ba06b81558d6ba34ad12, b7f29543501f90da68465259a4f8122ce5060229

Comment 4

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=c3341dadfb8bd94440a850e2a7d2e17c7a60d3f7

Comment 5

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=591e2d4fd3efec591a3bb3a94176dfd73319e839

Comment 6

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Ran 145 tests and 3724 subtests
OK     : 111
PASS   : 3448[linux32-debug,linux32-opt], 3453[linux64-debug,linux64-opt]
FAIL   : 276[linux32-debug,linux32-opt], 271[linux64-debug,linux64-opt]
TIMEOUT: 3
ERROR  : 31

New tests that have failures or other problems:
/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-channels.html
    # AUDIT TASK RUNNER FINISHED: 1 out of 1 tasks were failed.: FAIL
    < [validate .buffer] 2 out of 16 assertions were failed.: FAIL
    X source.buffer = buffer again did not throw an exception.: FAIL
    X source.buffer = new buffer did not throw an exception.: FAIL
/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-playbackrate-zero.html
    # AUDIT TASK RUNNER FINISHED: 1 out of 1 tasks were failed.: FAIL
    < [synthesize-verify] 1 out of 1 assertions were failed.: FAIL
    X The zero playbackRate should hold the sample value. Expected 0.5 but got 0.5001220703125 at the index 4097 Got false.: FAIL
/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiosource-time-limits.html: ERROR
/webaudio/the-audio-api/the-audiobuffersourcenode-interface/note-grain-on-play.html
    # AUDIT TASK RUNNER FINISHED: 1 out of 1 tasks were failed.: FAIL
    < [note-grain-on-play] 2 out of 206 assertions were failed.: FAIL
    X Number of grains out of 100 that ended at the wrong time is not equal to 0. Got 1.: FAIL
    X Pulse 75 boundary expected to be equal to the array [49613,50053] but differs in 1 places:
	Index	Actual			Expected
	[1]	5.0054000000000000e+4	5.0053000000000000e+4: FAIL
/webaudio/the-audio-api/the-audiobuffersourcenode-interface/note-grain-on-timing.html
    # AUDIT TASK RUNNER FINISHED: 1 out of 1 tasks were failed.: FAIL
    < [Test timing of noteGrainOn] 2 out of 105 assertions were failed.: FAIL
    X Number of grains out of 100 that ended at the wrong time is not equal to 0. Got 1.: FAIL
    X Pulse 75 boundary expected to be equal to the array [49613,50053] but differs in 1 places:
	Index	Actual			Expected
	[1]	5.0054000000000000e+4	5.0053000000000000e+4: FAIL

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e6ea2b642367
[wpt PR 10830] - Move AudioBufferSourceNode tests to WPT, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d3722145414
[wpt PR 10830] - Update wpt metadata, a=testonly

Comment 8

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/e6ea2b642367
https://hg.mozilla.org/mozilla-central/rev/4d3722145414