1459051 - GeckoView download support broken w/o content disposition

Status: RESOLVED FIXED

(GeckoView :: General, enhancement, P1)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

GeckoView chokes on a download if there is no content disposition due to an exception in GeckoViewHelperAppService.js

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1459051 - Fix GeckoView download support when missing content disposition

Review commit: https://reviewboard.mozilla.org/r/241580/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/241580/

Comment 2

[Eugen Sawin [:esawin]]

Comment on attachment 8973043 [details]
Bug 1459051 - Fix GeckoView download support when missing content disposition

https://reviewboard.mozilla.org/r/241580/#review247396

r+ with nit.

::: mobile/android/components/geckoview/GeckoViewExternalAppService.js:31
(Diff revision 1)
>      debug `doContent: uri=${channel.URI.displaySpec}
>                        contentType=${channel.contentType}`;
>  
> +    let filename = null;
> +    try {
> +      filename = channel.contentDispositionFilename;

Maybe add a comment that this throws NS_ERROR_NOT_AVAILABLE.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f24907e61976
Fix GeckoView download support when missing content disposition r=esawin

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f24907e61976