Closed Bug 1459051 Opened 6 years ago Closed 6 years ago

GeckoView download support broken w/o content disposition

Categories

(GeckoView :: General, enhancement, P1)

59 Branch
enhancement

Tracking

(firefox62 fixed)

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: snorp, Assigned: snorp)

Details

(Whiteboard: [geckoview:klar])

Attachments

(1 file)

GeckoView chokes on a download if there is no content disposition due to an exception in GeckoViewHelperAppService.js
Priority: -- → P1
Comment on attachment 8973043 [details]
Bug 1459051 - Fix GeckoView download support when missing content disposition

https://reviewboard.mozilla.org/r/241580/#review247396

r+ with nit.

::: mobile/android/components/geckoview/GeckoViewExternalAppService.js:31
(Diff revision 1)
>      debug `doContent: uri=${channel.URI.displaySpec}
>                        contentType=${channel.contentType}`;
>  
> +    let filename = null;
> +    try {
> +      filename = channel.contentDispositionFilename;

Maybe add a comment that this throws NS_ERROR_NOT_AVAILABLE.
Attachment #8973043 - Flags: review?(esawin) → review+
Pushed by jwillcox@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f24907e61976
Fix GeckoView download support when missing content disposition r=esawin
https://hg.mozilla.org/mozilla-central/rev/f24907e61976
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
Assignee: nobody → snorp
Product: Firefox for Android → GeckoView
Version: Firefox 59 → 59 Branch
Target Milestone: Firefox 62 → mozilla62
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: