1459215 - SignatureFirstDate API should return product-specific data

Status: RESOLVED WONTFIX

(Socorro :: Webapp, task)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

Socorro collects crashes for several products. For every crash, it generates a signature. Signature generation doesn't involve the product, so it's entirely possible for crashes for different products to have the same signature.

Crashes also have build ids. Build ids are also not product-specific--multiple products could product builds with the same build id.

Socorro currently keeps track of "first buildid" and "first report date" for signatures in the "signatures" table. It also maintains a "signature_product" table which has a foreign key to the "signtures" table, a foreign key to the "products" table, and a "first report date" field. In this way, we can answer "when was the first time we saw this signature?" as well as "when was the first time we saw this signature for this product?"

The webapp has a SignatureFirstDate API which takes signatures and returns the "first buildid" and "first report date". It doesn't take into account the product.

I claim this is an error. It may not be a big deal since Firefox comprises the bulk of incoming crashes and it's possibly the case that we only have problems with "vague" signatures like "OOM | Large".

This bug covers figuring out who's using that API and whether we should adjust it.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

This feels like a bug to me. It's possible that it's not a big deal right now because the vast majority of incoming crashes are Firefox. But if that ever changed, then I think this would be a problem.

Should we fix this API endpoint (and the underlying table and bookkeeping) to constrain on the product?

Comment 2

[Lonnen :lonnen]

We have a single product right now. Without evaluating if we should fix it eventually, I can confidently say "not until we add another product".

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

I'm going to WONTFIX this. We have multiple products, but they all effectively come from the same codebase, so the specific product doesn't matter so much.