Always store the last check pref

RESOLVED FIXED in Firefox 62

Status

()

enhancement
RESOLVED FIXED
Last year
Last year

People

(Reporter: leplatrem, Assigned: leplatrem)

Tracking

Trunk
Firefox 62
Points:
---

Firefox Tracking Flags

(firefox62 fixed)

Details

Attachments

(1 attachment)

In blocklist clients, we have a preference for each collection that we update every time a successful sync was done (eg. "services.blocklist.addons.checked")

By default, when using the RemoteSettings client, we don't do it because we didn't find any strong reason to keep this feature.

Shall we remove it everywhere?

If not, we should probably enable it everywhere (with default "services.settings.{bucket}-{collection}.last_checked")

See:
https://searchfox.org/mozilla-central/rev/c0d81882c7941c4ff13a50603e37095cdab0d1ea/services/common/remote-settings.js#411-414
Mark, do you remember why you added that last check pref?

Do you think we should keep it to inspect its value for debugging, testing or other purpose?

Thanks!
Flags: needinfo?(mgoodwin)
(In reply to Mathieu Leplatre (:leplatrem) from comment #1)
> Mark, do you remember why you added that last check pref?

We use(d?) it for finding out if the cert blocklist was stale. It's probably fine to use services.settings.{bucket}-{collection}.last_checked
Flags: needinfo?(mgoodwin)
Assignee: nobody → mathieu
Summary: Shall we store the last check pref ? → Always store the last check pref
Target Milestone: --- → Firefox 62
Version: 57 Branch → Trunk
Comment on attachment 8974372 [details]
Bug 1459243 - Always store last check pref in RemoteSettings

https://reviewboard.mozilla.org/r/242730/#review248538
Attachment #8974372 - Flags: review?(mgoodwin) → review+
Keywords: checkin-needed
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/66f099c14bd9
Always store last check pref in RemoteSettings r=mgoodwin
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/66f099c14bd9
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.