1459243 - Always store the last check pref

Status: RESOLVED FIXED

(Firefox :: Remote Settings Client, enhancement)

Description

[Mathieu Leplatre [:leplatrem]]

In blocklist clients, we have a preference for each collection that we update every time a successful sync was done (eg. "services.blocklist.addons.checked")

By default, when using the RemoteSettings client, we don't do it because we didn't find any strong reason to keep this feature.

Shall we remove it everywhere?

If not, we should probably enable it everywhere (with default "services.settings.{bucket}-{collection}.last_checked")

See:
https://searchfox.org/mozilla-central/rev/c0d81882c7941c4ff13a50603e37095cdab0d1ea/services/common/remote-settings.js#411-414

Comment 1

[Mathieu Leplatre [:leplatrem]]

Mark, do you remember why you added that last check pref?

Do you think we should keep it to inspect its value for debugging, testing or other purpose?

Thanks!

Comment 2

[Mark Goodwin [:mgoodwin]]

(In reply to Mathieu Leplatre (:leplatrem) from comment #1)
> Mark, do you remember why you added that last check pref?

We use(d?) it for finding out if the cert blocklist was stale. It's probably fine to use services.settings.{bucket}-{collection}.last_checked

Comment 3

[Mathieu Leplatre [:leplatrem]]

Attachment: Bug 1459243 - Always store last check pref in RemoteSettings

Review commit: https://reviewboard.mozilla.org/r/242730/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/242730/

Comment 4

[Mark Goodwin [:mgoodwin]]

Comment on attachment 8974372 [details]
Bug 1459243 - Always store last check pref in RemoteSettings

https://reviewboard.mozilla.org/r/242730/#review248538

Comment 5

[Mathieu Leplatre [:leplatrem]]

Comment on attachment 8974372 [details]
Bug 1459243 - Always store last check pref in RemoteSettings

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/242730/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/66f099c14bd9
Always store last check pref in RemoteSettings r=mgoodwin

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/66f099c14bd9