Closed Bug 1459249 Opened 2 years ago Closed Last year

reconfigure windows try builds to be like esr52 windows builds

Categories

(Release Engineering :: General, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: bhearsum, Assigned: Callek)

Details

Attachments

(4 files)

Windows buildbot try builds are currently busted if you push esr52 to try. Now that buildbot is dead on every other branch, we should reconfigure those try builds to be like esr52, which *should* fix them up.

I think the most important aspect of this will end up being the machine type. Try currently uses y-2008-spot, while esr52 uses b-2008-spot. There might be other notable differences too, but just changing that is probably a good start.

We might need to tweak watch pending to make sure things get spun up correctly, too.
My memory could be wrong, but I thought using b-2008* was a bad idea with regard to variations in on-system keys/secrets and signing related support.
If we do end up switching the instance type (and I'm not 100% sure it's the right idea after Callek's comment), there's at least of couple of things that need to be touched:
https://hg.mozilla.org/build/buildbot-configs/file/tip/mozilla/try_localconfig.py
https://github.com/mozilla-releng/build-cloud-tools/blob/master/configs/watch_pending.cfg#L37
(In reply to Justin Wood (:Callek) from comment #1)
> My memory could be wrong, but I thought using b-2008* was a bad idea with
> regard to variations in on-system keys/secrets and signing related support.

@callek, could you explain more? Perhaps you could help mentor ciduty on how to fix up try so that buildbot win build jobs can run for devs. Seems there is a lot of interest on being able to do this.
Flags: needinfo?(bugspam.Callek)
Component: General Automation → General
Diffed on dev-master2
Assignee: nobody → bugspam.Callek
Flags: needinfo?(bugspam.Callek)
I'm running a full dump_master diff now, to paste to this bug. On the downside though, I don't actually know how to test this other than push to production and then have someone push to try with esr52, if anyone has ideas by all means.
Comment on attachment 8974837 [details]
Bug 1459249 - Reconfigure try BB to be like esr52. r=nthomas

Nick Thomas [:nthomas] (UTC+12) has approved the revision.

https://phabricator.services.mozilla.com/D1259
Attachment #8974837 - Flags: review+
..I may have solved this without deploying that buildbot patch... https://treeherder.mozilla.org/#/jobs?repo=try&revision=6f01b64c036ee6275fa9ef0f2b927bfe8b95de49

:Ryan, is there (much) value in re-adding linux and osx buildbot builders for try?
Flags: needinfo?(ryanvm)
Comment on attachment 8974876 [details]
Bug 1459249 - Make esr52's code work on try by explicitly setting pypi servers and dealing with pip index. r=rail

Rail Aliiev [:rail] ⌚️ET has approved the revision.

https://phabricator.services.mozilla.com/D1260
Attachment #8974876 - Flags: review+
(In reply to Justin Wood (:Callek) from comment #10)
> :Ryan, is there (much) value in re-adding linux and osx buildbot builders
> for try?

Yes. It's still where our build and test coverage is on those platforms.
Flags: needinfo?(ryanvm)
JUstin, do we still care about that?
Flags: needinfo?(bugspam.Callek)
I don't think so. Now that esr-52 and buildbot are gone, this bug shouldn't require follow up. Callek can revert if I'm missing something.
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → INVALID
Flags: needinfo?(bugspam.Callek)
You need to log in before you can comment on or make changes to this bug.