1459249 - reconfigure windows try builds to be like esr52 windows builds

Status: RESOLVED INVALID

(Release Engineering :: General, enhancement)

Description

[[e-mail] (:bhearsum)]

Windows buildbot try builds are currently busted if you push esr52 to try. Now that buildbot is dead on every other branch, we should reconfigure those try builds to be like esr52, which *should* fix them up.

I think the most important aspect of this will end up being the machine type. Try currently uses y-2008-spot, while esr52 uses b-2008-spot. There might be other notable differences too, but just changing that is probably a good start.

We might need to tweak watch pending to make sure things get spun up correctly, too.

Comment 1

[Justin Wood (:Callek)]

My memory could be wrong, but I thought using b-2008* was a bad idea with regard to variations in on-system keys/secrets and signing related support.

Comment 2

[[e-mail] (:bhearsum)]

If we do end up switching the instance type (and I'm not 100% sure it's the right idea after Callek's comment), there's at least of couple of things that need to be touched:
https://hg.mozilla.org/build/buildbot-configs/file/tip/mozilla/try_localconfig.py
https://github.com/mozilla-releng/build-cloud-tools/blob/master/configs/watch_pending.cfg#L37

Comment 3

[Jordan Lund (:jlund)]

(In reply to Justin Wood (:Callek) from comment #1)
> My memory could be wrong, but I thought using b-2008* was a bad idea with
> regard to variations in on-system keys/secrets and signing related support.

@callek, could you explain more? Perhaps you could help mentor ciduty on how to fix up try so that buildbot win build jobs can run for devs. Seems there is a lot of interest on being able to do this.

Comment 4

[Phabricator Automation]

Attachment: Bug 1459249 - Reconfigure try BB to be like esr52. r=nthomas

Comment 5

[Justin Wood (:Callek)]

Attachment: $ diff -U0 ~/clean_builder_list.txt ~/dirty_builder_list.txt | sort -u

Diffed on dev-master2

Comment 6

[Justin Wood (:Callek)]

I'm running a full dump_master diff now, to paste to this bug. On the downside though, I don't actually know how to test this other than push to production and then have someone push to try with esr52, if anyone has ideas by all means.

Comment 7

[Phabricator Automation]

Comment on attachment 8974837 [details]
Bug 1459249 - Reconfigure try BB to be like esr52. r=nthomas

Nick Thomas [:nthomas] (UTC+12) has approved the revision.

https://phabricator.services.mozilla.com/D1259

Comment 8

[Justin Wood (:Callek)]

Note to self, a try push (prior to this bug) of esr is: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e84da1947eee900dd8c834577e4256ce65a04943

Comment 9

[Justin Wood (:Callek)]

Attachment: Diff of full dump_masters

Comment 10

[Justin Wood (:Callek)]

..I may have solved this without deploying that buildbot patch... https://treeherder.mozilla.org/#/jobs?repo=try&revision=6f01b64c036ee6275fa9ef0f2b927bfe8b95de49

:Ryan, is there (much) value in re-adding linux and osx buildbot builders for try?

Comment 11

[Phabricator Automation]

Attachment: Bug 1459249 - Make esr52's code work on try by explicitly setting pypi servers and dealing with pip index. r=rail

reconfigure windows try builds to be like esr52 windows builds

Comment 12

[Phabricator Automation]

Comment on attachment 8974876 [details]
Bug 1459249 - Make esr52's code work on try by explicitly setting pypi servers and dealing with pip index. r=rail

Rail Aliiev [:rail] ⌚️ET has approved the revision.

https://phabricator.services.mozilla.com/D1260

Comment 13

[Justin Wood (:Callek)]

https://hg.mozilla.org/releases/mozilla-esr52/rev/207f53418d8642e487558d98d8b576d2eafba574

Comment 14

[Ryan VanderMeulen [:RyanVM]]

(In reply to Justin Wood (:Callek) from comment #10)
> :Ryan, is there (much) value in re-adding linux and osx buildbot builders
> for try?

Yes. It's still where our build and test coverage is on those platforms.

Comment 15

[Justin Wood (:Callek)]

Ok, lets see if this works...

https://hg.mozilla.org/build/buildbot-configs/rev/d5b501df0bc75aae0f45f53cbf66b0c75fe69c2a
https://hg.mozilla.org/build/buildbot-configs/rev/4dcae2d97474326f52058ff0c4d0ad71088db7cf

Comment 16

[Sylvestre Ledru [:Sylvestre]]

JUstin, do we still care about that?

Comment 17

[Jordan Lund (:jlund)]

I don't think so. Now that esr-52 and buildbot are gone, this bug shouldn't require follow up. Callek can revert if I'm missing something.