1459297 - Use SDK calls for boxing/unboxing GeckoBundle values

Status: RESOLVED FIXED

(GeckoView :: General, enhancement, P3)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

To improve efficiency, use SDK calls rather than static methods to box/unbox GeckoBundle values.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1459297 - Use SDK JNI calls for boxing/unboxing GeckoBundle values;

Instead of the helper methods in GeckoBundle, add SDK JNI calls for the
boxing/unboxing operations, and use those calls directly. Moreover, for
unboxing Boolean/Double/Integer, use their internal "value" field value
directly if possible, to avoid making a JNI method call.

Review commit: https://reviewboard.mozilla.org/r/242046/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/242046/

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8973683 [details]
Bug 1459297 - Use SDK JNI calls for boxing/unboxing GeckoBundle values;

https://reviewboard.mozilla.org/r/242046/#review247974

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b6f2518b404
Use SDK JNI calls for boxing/unboxing GeckoBundle values; r=snorp

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/5b6f2518b404