Closed Bug 1459307 Opened 2 years ago Closed 1 year ago
RTC screensharing menu does not disable the allow button when switching between inputs
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0 Build ID: 20180427210249 Steps to reproduce: - use a WebRTC CLient website - click on screen sharing - select any application windows other than firefox - click on "Entscheidung merken" (ger.), should be equal to "remember my selection" or similar - select the firefox window from dropdown menu Actual results: I'm able to click on "Erlauben" ~ "allow" Expected results: There should be the red message, saying firefox won't allow permanent access to my screen.
Severity: normal → trivial
Component: Untriaged → Site Identity and Permission Panels
Ah, good find! I think this is un-severe enough to be a mentored bug. You can test the bug on https://mozilla.github.io/webrtc-landing/gum_test.html (select "Window" and switch between inputs using the dropdown). The problem lies in the way we deal with commands on the dropdown using the _onCommand function: https://searchfox.org/mozilla-central/rev/b28b94dc81d60c6d9164315adbd4a5073526d372/toolkit/modules/PopupNotifications.jsm#1463 where it calls this._setNotificationUIState(notificationEl); without passing the second parameter that specifies the checkbox state. Instead, the _onCommand should do something similar to the _onCheckboxCommand function to pass the second parameter correctly: https://searchfox.org/mozilla-central/rev/b28b94dc81d60c6d9164315adbd4a5073526d372/toolkit/modules/PopupNotifications.jsm#1447 It would also be great to update this test: https://searchfox.org/mozilla-central/rev/b28b94dc81d60c6d9164315adbd4a5073526d372/browser/base/content/test/webrtc/browser_devices_get_user_media_screen.js#513 to check that the button stays disabled when using the dropdown to change between screen sharing targets. Thanks!
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P3
Summary: WebRTC screensharing menu visual glitch → WebRTC screensharing menu does not disable the allow button when switching between inputs
Assignee: nobody → prathikshaprasadsuman
Status: NEW → ASSIGNED
Switching between menu options should maintain correct main action state when window sharing is requested.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/8d8c2a0e01b4 Switching between menu options should maintain correct main action state when window sharing is requested. r=johannh
You need to log in before you can comment on or make changes to this bug.