1459309 - currentScript should be null when evaluating scripts from shadow DOM

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Description

[Olli Pettay [:smaug][[e-mail]]]

Attachment: shadow_current_script.diff

Fixing also the test.
Better to null check before accessing the variable and there are two tests with the same name and there is a warning about that in the console.

remote: 
remote: View your change here:
remote:   https://hg.mozilla.org/try/rev/258d3457761190cebc4f2dbf413961a750366a94
remote: 
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=258d3457761190cebc4f2dbf413961a750366a94
remote: recorded changegroup in replication log in 0.100s

Comment 1

[Peter Van der Beken [:peterv]]

Comment on attachment 8973311 [details] [diff] [review]
shadow_current_script.diff

Review of attachment 8973311 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/script/ScriptLoader.h
@@ +57,5 @@
>        , mScriptLoader(aScriptLoader)
>      {
> +      nsCOMPtr<nsINode> node = do_QueryInterface(aCurrentScript);
> +      mScriptLoader->mCurrentScript =
> +        node && !node->IsInShadowTree() ? aCurrentScript : nullptr;

Hmm, not sure how node can be null here?

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Because when dealing with JS modules, aCurrentScript is null.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

oh, I never landed this

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/29b727bc2caa
currentScript should be null when evaluating scripts from shadow DOM, r=peterv

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/w3c/web-platform-tests/pull/11119 for changes under testing/web-platform/tests

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/29b727bc2caa

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged