1459311 - Don't put source files which are completely uncovered in the per-test reports

Status: RESOLVED FIXED

(Testing :: Code Coverage, enhancement)

Description

[Marco Castelluccio [:marco]]

In per-test reports, we only want to know about covered files. Removing uncovered files will make the reports way smaller (especially after bug 1455401).

Comment 1

[Marco Castelluccio [:marco]]

Attachment: Patch

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8973369 [details] [diff] [review]
Patch

Review of attachment 8973369 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/mozharness/mozharness/mozilla/testing/codecoverage.py
@@ -310,4 @@
>                          with open(grcov_file, 'w') as f:
>                              json.dump({
>                                  'test': test,
> -                                'suite': suite,

why did you remove 'suite' ?

Comment 3

[Greg Mierzwinski [:sparky]]

Comment on attachment 8973369 [details] [diff] [review]
Patch

Review of attachment 8973369 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me. But one thing I am wondering is if this could affect the UIs at all, considering that they look at uncovered lines in files?

I am also wondering about the same thing :jmaher asked. I think the suite can be useful information to know, and it doesn't really add anything to the overall space.

Comment 4

[Greg Mierzwinski [:sparky]]

:marco, would you have a try run with these changes running in it?

Comment 5

[Marco Castelluccio [:marco]]

(In reply to Greg Mierzwinski [:sparky] from comment #3)
> This looks good to me. But one thing I am wondering is if this could affect
> the UIs at all, considering that they look at uncovered lines in files?

It shouldn't affect the UIs, this will just mean that some files will be missing in ActiveData (files that are completely uncovered) for some tests.

> I am also wondering about the same thing :jmaher asked. I think the suite
> can be useful information to know, and it doesn't really add anything to the
> overall space.

Yeah I don't know why I removed it, I agree it should be there.

(In reply to Greg Mierzwinski [:sparky] from comment #4)
> :marco, would you have a try run with these changes running in it?

Here it is: https://treeherder.mozilla.org/#/jobs?repo=try&revision=72d244adca41ebba94c8239cb4b9febc2e9eaa2e.

Comment 6

[Greg Mierzwinski [:sparky]]

:marco, thanks for the link everything looks good to go. Artifacts look like they have decreased in size now too

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/00630f737536
Remove completely uncovered files from per-test reports. r=jmaher,sparky

Comment 8

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/00630f737536