1459317 - Compare a TFO connection and a backup connection according to TLS connection establishment

Status: NEW

(Core :: Networking: HTTP, enhancement, P5)

Description

[Dragana Damjanovic [:dragana]]

Attachment: bug_race_tls_connect_by_tfo.patch

Currently we close a TFO connection if its backup connection has established the TCP connection faster. Even though the TCP connection is slower the end of the TLS handshake can be faster because TFO saves a RTT.

We should not close a TFO connection when the backup connection finishes TCP handshake but wait for the TLS handshake finish.

Comment 1

[Dragana Damjanovic [:dragana]]

Comment on attachment 8973319 [details] [diff] [review]
bug_race_tls_connect_by_tfo.patch

Sorry, I want to change one small thing.

Comment 2

[Dragana Damjanovic [:dragana]]

Attachment: bug_race_tls_connect_by_tfo.patch

Comment 3

[Dragana Damjanovic [:dragana]]

Comment on attachment 8974974 [details] [diff] [review]
bug_race_tls_connect_by_tfo.patch

Francois, please take a look at the telemetry change. I have only renamed the probe and change the max number to 40.

Comment 4

[François Marier [:francois]]

Comment on attachment 8974974 [details] [diff] [review]
bug_race_tls_connect_by_tfo.patch

Review of attachment 8974974 [details] [diff] [review]:
-----------------------------------------------------------------

This has already been reviewed on https://bugzilla.mozilla.org/show_bug.cgi?id=1390881#c6 and we're still collecting the same data, so datareview+.

::: toolkit/components/telemetry/Histograms.json
@@ +2025,2 @@
>      "alert_emails": ["[e-mail]", "[e-mail]"],
>      "bug_numbers": [1402879]

Please add 1459317 and 1390881 to that list so that we can easily keep track of the different times when this data collection was reviewed and revised.

Comment 5

[Dragana Damjanovic [:dragana]]

Attachment: bug_race_tls_connect_by_tfo.patch

Added the bug number in Histograms.json