Closed
Bug 1459351
Opened 6 years ago
Closed 6 years ago
Warn if 'mach android-emulator' is requested to start an x86 emulator without kvm-ok, on linux
Categories
(Firefox for Android Graveyard :: Testing, defect)
Firefox for Android Graveyard
Testing
Tracking
(firefox61 wontfix, firefox62 fixed)
RESOLVED
FIXED
Firefox 62
People
(Reporter: gbrown, Assigned: gbrown)
References
Details
Attachments
(1 file)
|
1.79 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
On Linux, the current android x86 emulator will not start unless kvm acceleration is available. The resulting failure is generic, with the cause only decipherable by close examination of emulator.log. Instead of letting that happen, let's add some smarts to 'mach android-emulator'.
|
Assignee | |
Comment 1•6 years ago
|
||
A simple check for kvm acceleration before running the x86 emulator: Hopefully the additional diagnostics will help avoid some confusion.
Attachment #8973770 -
Flags: review?(jmaher)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8973770 [details] [diff] [review] on linux, if x86 emulator requested, check '-accel-check' Review of attachment 8973770 [details] [diff] [review]: ----------------------------------------------------------------- this looks reasonable!
Attachment #8973770 -
Flags: review?(jmaher) → review+
Pushed by gbrown@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/abd2b3aec711 Warn when 'mach android-emulator' tries to start an x86 emulator without kvm; r=jmaher
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/abd2b3aec711
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
|
|
||
Updated•6 years ago
|
Target Milestone: Firefox 61 → Firefox 62
|
||
Updated•6 years ago
|
|
||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•