1459351 - Warn if 'mach android-emulator' is requested to start an x86 emulator without kvm-ok, on linux

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Testing, defect)

Description

[Geoff Brown [:gbrown]]

On Linux, the current android x86 emulator will not start unless kvm acceleration is available. The resulting failure is generic, with the cause only decipherable by close examination of emulator.log. Instead of letting that happen, let's add some smarts to 'mach android-emulator'.

Comment 1

[Geoff Brown [:gbrown]]

Attachment: on linux, if x86 emulator requested, check '-accel-check'

A simple check for kvm acceleration before running the x86 emulator: Hopefully the additional diagnostics will help avoid some confusion.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8973770 [details] [diff] [review]
on linux, if x86 emulator requested, check '-accel-check'

Review of attachment 8973770 [details] [diff] [review]:
-----------------------------------------------------------------

this looks reasonable!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/abd2b3aec711
Warn when 'mach android-emulator' tries to start an x86 emulator without kvm; r=jmaher

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/abd2b3aec711