Closed Bug 1459412 Opened Last year Closed Last year

Port bug 1457007 to TB: Add about:support information on if tiling is used in the content process

Categories

(Thunderbird :: General, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 61.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch aboutTiling.patch (obsolete) — Splinter Review
I see no new entry in TB and also not in FX. But also no error in console.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8973448 - Flags: review?(jorgk)
Comment on attachment 8973448 [details] [diff] [review]
aboutTiling.patch

Not particularly useful since judging by the comments in bug 1457007, this is for the content processes, that it, multi-process FF (e10s).

I'd be happy to land this as a comment only, like:
+    // addRowFromKey("features", "contentUsesTiling"); - For content processes in Firefox.

What do you think?
Attachment #8973448 - Flags: review?(jorgk) → review+
(In reply to Jorg K (GMT+1) from comment #2)
> Comment on attachment 8973448 [details] [diff] [review]
> aboutTiling.patch
> 
> Not particularly useful since judging by the comments in bug 1457007, this
> is for the content processes, that it, multi-process FF (e10s).
> 
> I'd be happy to land this as a comment only, like:
> +    // addRowFromKey("features", "contentUsesTiling"); - For content
> processes in Firefox.
> 
> What do you think?

There is nothing shown when the feature isn't enabled/used, so no need to comment it out. Or have you something seen?
I didn't try. But we run code that we know won't do anything useful in TB. To keep in sync, I'd add a comment.
A compromise, comment after the code. If you don't like it you can land it completely commented out.
Attachment #8973448 - Attachment is obsolete: true
Attachment #8973472 - Flags: review?(jorgk)
Comment on attachment 8973472 [details] [diff] [review]
aboutTiling.patch

Yes, I think it doesn't buy us anything.
Attachment #8973472 - Flags: review?(jorgk) → review+
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/83d0c780efc5
Port bug 1457007 to TB: Add about:support information on if tiling is used in the content process. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: Last year
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 61.0
You need to log in before you can comment on or make changes to this bug.