1459412 - Port bug 1457007 to TB: Add about:support information on if tiling is used in the content process

Status: RESOLVED FIXED

(Thunderbird :: General, enhancement)

Description

[Richard Marti (:Paenglab)]

Bug 1457007 added this line to aboutSupport.js: https://hg.mozilla.org/mozilla-central/rev/2a7aef0304b2#l7.12

Comment 1

[Richard Marti (:Paenglab)]

Attachment: aboutTiling.patch

I see no new entry in TB and also not in FX. But also no error in console.

Comment 2

[Jorg K (CEST = GMT+2)]

Comment on attachment 8973448 [details] [diff] [review]
aboutTiling.patch

Not particularly useful since judging by the comments in bug 1457007, this is for the content processes, that it, multi-process FF (e10s).

I'd be happy to land this as a comment only, like:
+    // addRowFromKey("features", "contentUsesTiling"); - For content processes in Firefox.

What do you think?

Comment 3

[Richard Marti (:Paenglab)]

(In reply to Jorg K (GMT+1) from comment #2)
> Comment on attachment 8973448 [details] [diff] [review]
> aboutTiling.patch
> 
> Not particularly useful since judging by the comments in bug 1457007, this
> is for the content processes, that it, multi-process FF (e10s).
> 
> I'd be happy to land this as a comment only, like:
> +    // addRowFromKey("features", "contentUsesTiling"); - For content
> processes in Firefox.
> 
> What do you think?

There is nothing shown when the feature isn't enabled/used, so no need to comment it out. Or have you something seen?

Comment 4

[Jorg K (CEST = GMT+2)]

I didn't try. But we run code that we know won't do anything useful in TB. To keep in sync, I'd add a comment.

Comment 5

[Richard Marti (:Paenglab)]

Attachment: aboutTiling.patch

A compromise, comment after the code. If you don't like it you can land it completely commented out.

Comment 6

[Jorg K (CEST = GMT+2)]

Comment on attachment 8973472 [details] [diff] [review]
aboutTiling.patch

Yes, I think it doesn't buy us anything.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/83d0c780efc5
Port bug 1457007 to TB: Add about:support information on if tiling is used in the content process. r=jorgk