Closed Bug 145947 Opened 18 years ago Closed 8 years ago
Occurences of uninitialized variables being used before being set (in modules/plugin)
This bug is just for the "xxx might be used uninitialized" warnings in various source files in modules/plugin. Currently (http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1021964760.29906.gz&fulltext=1 - Tue, 21 May 2002 03:06 -0400) TBox shows the following warnings: modules/plugin/base/src/nsPluginHostImpl.cpp:5878 `nsresult rv' might be used uninitialized in this function modules/plugin/samples/default/unix/nullplugin.c:186 `ele_prev' might be used uninitialized in this function
Bug 59652 is the meta-bug tracking the fight against these (potentially very nasty) warnings.
Does this patch help the warning in nsPluginHostImpl.cpp?
It may be better to propagate up the do_GetService error instead of using the generic NS_ERROR_FAILURE. This patch also fixes another similar warning (that for some reason only shows on my machine, but not on TBox).
handing over to serge
Assignee: beppe → serge
Priority: -- → P3
Target Milestone: --- → mozilla1.2alpha
Comment on attachment 84459 [details] [diff] [review] Alternative solution I assume this shows only on yours box. >- char *p; // tmp ptr into new output buf >+ char *p = nsnull; // tmp ptr into new output buf actually this pointer is not in use before first assignment, so smart enough compiler should not warn on this. r=serge
Attachment #84459 - Flags: review+
Whiteboard: [PL2:NA][NEED SR=]
Target Milestone: mozilla1.2alpha → mozilla1.0.2
17 years ago
Assignee: serge → peterl
Whiteboard: [PL2:NA][NEED SR=] → [PL2:NA][patch needs revisiting]
Target Milestone: mozilla1.3alpha → Future
Summary: Occurances of uninitialized variables being used before being set (in modules/plugin) → Occurences of uninitialized variables being used before being set (in modules/plugin)
modules/plugin/base/src/nsPluginHostImpl.cpp no longer exists.
modules/plugin directory does not exist anymore and hence closing this bug.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.