145947 - Occurences of uninitialized variables being used before being set (in modules/plugin)

Status: RESOLVED WORKSFORME

(Core Graveyard :: Plug-ins, defect, P3)

Description

[Aleksey Nogin]

This bug is just for the "xxx might be used uninitialized" warnings in various
source files in modules/plugin. Currently
(http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1021964760.29906.gz&fulltext=1
- Tue, 21 May 2002 03:06 -0400) TBox shows the following warnings:

modules/plugin/base/src/nsPluginHostImpl.cpp:5878
 `nsresult rv' might be used uninitialized in this function

modules/plugin/samples/default/unix/nullplugin.c:186
 `ele_prev' might be used uninitialized in this function

Comment 1

[Aleksey Nogin]

Bug 59652 is the meta-bug tracking the fight against these (potentially very
nasty) warnings.

Comment 2

[Peter Lubczynski]

Attachment: possible patch?

Does this patch help the warning in nsPluginHostImpl.cpp?

Comment 3

[Aleksey Nogin]

Attachment: Alternative solution

It may be better to propagate up the do_GetService error instead of using the
generic NS_ERROR_FAILURE. 

This patch also fixes another similar warning (that for some reason only shows
on my machine, but not on TBox).

Comment 4

[rubydoo123]

handing over to serge

Comment 5

[serge (gone)]

Comment on attachment 84459 [details] [diff] [review]
Alternative solution

I assume this shows only on yours box.
>-  char *p; // tmp ptr into new output buf
>+  char *p = nsnull; // tmp ptr into new output buf
actually this pointer is not in use before first assignment, so smart enough
compiler should not warn on this.
r=serge

Comment 6

[rubydoo123]

future

Comment 7

[Takanori MATSUURA]

modules/plugin/base/src/nsPluginHostImpl.cpp no longer exists.

Comment 8

[Atul Aggarwal]

modules/plugin directory does not exist anymore and hence closing this bug.