1459597 - Firefox executables properties show ../../dist/bin/… as Original filename

Status: RESOLVED FIXED

Description

[Rajesh Nair]

Attachment: Firefox Developer version Path.JPG

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0
Build ID: 20180503152818

Steps to reproduce:

The Firefox Developer version shows invalid file name. From the Firefox properties the Original filename shows like this  "../../dist/bin/firefox.exe" 




Expected results:

The Original file name should be Firefox.exe

Comment 1

[Gingerbread Man]

:Gijs, a little help please. If I click the Component drop-down box here, Build Config is missing from both Firefox and Core. Is that normal — does moving and filing reports there require special privileges?

crashreporter.exe
../../../dist/bin/crashreporter.exe

firefox.exe
../../dist/bin/firefox.exe

maintenanceservice.exe
../../../dist/bin/maintenanceservice.exe

maintenanceservice_installer.exe
maintenanceservice_installer.exe
^ this one's OK!

minidump-analyzer.exe
../../../dist/bin/minidump-analyzer.exe

pingsender.exe
../../../../dist/bin/pingsender.exe

plugin-container.exe
../../dist/bin/plugin-container.exe

plugin-hang-ui.exe
../../../../dist/bin/plugin-hang-ui.exe

updater.exe
../../../../dist/bin/updater.exe

Comment 2

[:Gijs (he/him)]

I think the build stuff moved to its own product...

Comment 3

[(not currently active) Ted Mielczarek]

Almost certainly a regression from bug 1255485. I don't think this is harmful, it's just for display.

Looks like we could just wrap the argument to `-BINARY` in `$(notdir)` here:
https://dxr.mozilla.org/mozilla-central/rev/2d95d70298e248161b629ef1d0d57049c0b62d71/config/version.mk#25

Comment 4

[(not currently active) Ted Mielczarek]

Attachment: bug 1459597 - fix Original Filename display in Windows file version info.

Review commit: https://reviewboard.mozilla.org/r/243412/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/243412/

Comment 5

[(not currently active) Ted Mielczarek]

Attachment: Fixed version info in my local build

The original filename looks sensible in my local build with this patch.

Comment 6

[(not currently active) Ted Mielczarek]

We should be able to uplift this to beta once it lands, it's a trivial patch and bug 1255485 is on beta.

Comment 7

[Chris Manchester (Mostly Offline until July 29)]

Comment on attachment 8975069 [details]
bug 1459597 - fix Original Filename display in Windows file version info.

https://reviewboard.mozilla.org/r/243412/#review249794

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bad54bae22fa
fix Original Filename display in Windows file version info. r=chmanchester

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/bad54bae22fa

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Please request Beta approval on this when you get a chance. No point in shipping this regression for a release when it's easily avoidable.

Comment 11

[(not currently active) Ted Mielczarek]

Comment on attachment 8975069 [details]
bug 1459597 - fix Original Filename display in Windows file version info.

Approval Request Comment
[Feature/Bug causing the regression]: bug 
1255485 
[User impact if declined]: Minor cosmetic ugliness in the Windows Explorer file Properties dialog's "Detail" pane.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]:  No
[List of other uplifts needed for the feature/fix]: N/A
[Is the change risky?]: No
[Why is the change risky/not risky?]: Changes a string that is embedded in the file's resource section but is not used for anything else.
[String changes made/needed]: N/A

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8975069 [details]
bug 1459597 - fix Original Filename display in Windows file version info.

Fixes a cosmetic bug in Windows Explorer introduced in Fx61. Approved for 61.0b7.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5cca2364cc58