Closed
Bug 1459635
Opened 7 years ago
Closed 7 years ago
New share sheet needs XCUITests
Categories
(Firefox for iOS :: General, enhancement, P3)
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
fxios | 12.0 | --- |
People
(Reporter: garvan, Assigned: isabel_rios)
References
Details
Attachments
(1 file)
The share extensions hve been refactored for v12.0 into a single multi-selection share sheet.
I am hopeful XCUITest supports extension testing well enough to use this framework to test this feature.
Updated•7 years ago
|
Assignee | ||
Comment 2•7 years ago
|
||
There are three new tests covering this share sheet. There are some scenarios that are not possible to create XCUItests for the E2E scenario, but at least there are some checks for this share sheet now. Let me know if those are fine or more checks/tests should be included.
Thanks!
Attachment #8977109 -
Flags: review?(gkeeley)
Comment on attachment 8977109 [details] [review]
Pull Request
Great stuff! We can re-use this code also for L10N screenshot automation
Attachment #8977109 -
Flags: review?(gkeeley) → review+
Assignee | ||
Comment 4•7 years ago
|
||
Great that this can be re-used!
Merged on master: https://github.com/mozilla-mobile/firefox-ios/commit/2febdb3311594f31c254ec229aa2ed0921d8324d
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [needsuplift]
Assignee | ||
Comment 5•7 years ago
|
||
uplifted to v12.x https://github.com/mozilla-mobile/firefox-ios/commit/d144df128ebd9285a422168464fc06bcdeb031a9
Whiteboard: [needsuplift]
You need to log in
before you can comment on or make changes to this bug.
Description
•