1459639 - "Enterprise policies" errors displayed in Browser Console

Status: RESOLVED INVALID

(Firefox :: Enterprise Policies, defect)

Description

[Camelia Badau [:cbadau], Desktop Test Engineering]

Attachment: policies.json

[Affected versions]:
- Firefox 60 RC
- Firefox 60 ESR 

[Affected platforms]:
- Windows 7 x64
- Windows 10 x64
- Ubuntu 14.04 x64
- macOS 10.13

[Steps to reproduce]:
1. Launch Firefox. 
2. Go to about:config and set devtools.chrome.enabled = true.
3. In the browser console run: Services.dirsvc.get("XREAppDist", Ci.nsIFile).path. Create a folder in that directory and call it "distribution".
4. Save the "policies.json" file from the attachment in the "distribution" folder.
5. Restart the browser, open Browser Console and verify there is no error in the browser console related to "Enterprise policies".
6. Go to about:preferences#privacy and verify "Remember logins and passwords for websites" is unchecked and greyed out. 
7. Go to about:preferences#privacy and verify "use a master password" is unchecked and greyed out. 

[Expected result]:
- At step 5, no errors related to enterprise policy are displayed.
- At step 6, "Remember logins and passwords for website" is unchecked and greyed out.
- At step 7, "Use a master password" is unchecked and greyed out. 

[Actual result]:
- At step 5, the following errors are displayed in Browser Console: 
"Enterprise Policies:Policy DisableAppUpdate is only allowed on ESR  
Enterprise Policies:Unknown policy: InstallAddons  
Enterprise Policies:Unknown policy: BlockSetDesktopBackground  
Enterprise Policies:Unknown policy: RememberPasswords
Enterprise Policies:Unknown policy: CreateMasterPassword"
- At step 6, "Remember logins and passwords for website" is checked and is NOT greyed out.
- At step 7, "Use a master password" is unchecked, but is NOT greyed out.

[Regression range]:
- TBD

[Additional notes]:
- The issue is NOT reproducible on Firefox 60 Beta 6, but is reproducible on Firefox 60 Beta 16.

Comment 1

[Mike Kaply [:mkaply]]

We renamed this policy and did not let the test team know.

Please see:

https://reviewboard.mozilla.org/r/234624/diff/2#index_header

For this bug in particular, we changed CreateMasterPassword to DisableMasterPasswordCreation

Comment 2

[Mike Kaply [:mkaply]]

does changing this make it work?

Comment 3

[Camelia Badau [:cbadau], Desktop Test Engineering]

I've retested on Windows 7 x64 using ESR 60 build 6: 
1. In the policies.json I changed CreateMasterPassword to DisableMasterPasswordCreation=true => the "Enterprise Policies:Unknown policy: CreateMasterPassword" error isn't displayed anymore in Browser Console and the "Use a master password" is greyed out -> for "Master Password" everything works now

2. "Enterprise Policies:Policy DisableAppUpdate is only allowed on ESR  
Enterprise Policies:Unknown policy: InstallAddons  
Enterprise Policies:Unknown policy: BlockSetDesktopBackground  
Enterprise Policies:Unknown policy: RememberPasswords" => those errors are still displayed in Browser Console

3. "Remember logins and passwords for website" option is still checked and is NOT greyed out 

Any thoughts about 2 and 3?

Comment 4

[Mike Kaply [:mkaply]]

These policies were renamed as well.

Swe:

https://github.com/mozilla/policy-templates/blob/master/README.md

BlockSetDesktopBackground -> DisableSetDesktopBackground
RememberPasswords -> OfferToSaveLogins
InstallAddons -> InstallAddonsPermission

Comment 5

[:Felipe Gomes (needinfo for replies!)]

Those errors were due to the renaming we did for some of the policies