Closed Bug 1459661 Opened 7 years ago Closed 7 years ago

update to version of cargo-vendor with fix for local modification of vendored crates

Categories

(Firefox Build System :: General, enhancement)

3 Branch
enhancement
Not set
normal

Tracking

(firefox62 fixed)

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: myk, Assigned: myk)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Since landing bug 1323557, I discovered that while it's necessary to enable easy modification of vendored crates, it isn't sufficient for that purpose, because of an issue in cargo-vendor. I've submitted a fix for that issue in <https://github.com/alexcrichton/cargo-vendor/pull/71>. Once the issue is resolved, and a version of cargo-vendor with the fix is released, we should update to that version.
FWIW the `mach vendor rust` code just uses `cargo install` to install cargo-vendor on the developer's machine. We do have a minimum version check, you can bump that if required: https://dxr.mozilla.org/mozilla-central/rev/b1628ac71fcc15797baec6083650bfcde650f190/python/mozbuild/mozbuild/vendor_rust.py#40
Hmm, I'm not sure that it's worth forcing everyone to upgrade cargo-vendor for the subset of developers who want to modify vendored crates. I'll wait on this and see if it proves troublesome in practice after folks start doing so, f.e. in response to this message I've posted to dev-platform: https://groups.google.com/forum/#!topic/mozilla.dev.platform/TIjMPM1gdqU
Status: ASSIGNED → NEW
Only the people who run `mach vendor rust` would get the upgrade. That's a small enough set of people that I would just do it.
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #3) > Only the people who run `mach vendor rust` would get the upgrade. That's a > small enough set of people that I would just do it. Fair enough, patch submitted, and review requested!
Status: NEW → ASSIGNED
Comment on attachment 8975702 [details] Bug 1459661 - require cargo-vendor version 0.1.14. https://reviewboard.mozilla.org/r/243922/#review249856 ::: python/mozbuild/mozbuild/vendor_rust.py:122 (Diff revision 1) > self.log(logging.INFO, 'installing', {}, 'Installing cargo-vendor (this may take a few minutes)...') > env = self.check_openssl() > self.run_process(args=[cargo, 'install', 'cargo-vendor'], > append_env=env) > elif not self.check_cargo_vendor_version(cargo): > self.log(logging.INFO, 'cargo_vendor', {}, 'cargo-vendor >= 0.1.12 required; force-reinstalling (this may take a few minutes)...') This info message should be updated as well to reflect the new version.
Attachment #8975702 - Flags: review?(bugmail) → review+
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #6) > This info message should be updated as well to reflect the new version. Good point, fixed in the version I'll land.
Pushed by myk@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c130a4463704 require cargo-vendor version 0.1.14. r=kats
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Version: Version 3 → 3 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: